Bugzilla – Attachment 149733 Details for
Bug 33253
2FA - Form not excluded from autofill
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33253: Turn off autocompletion for 2FA authentication code
Bug-33253-Turn-off-autocompletion-for-2FA-authenti.patch (text/plain), 1.79 KB, created by
David Nind
on 2023-04-16 19:57:29 UTC
(
hide
)
Description:
Bug 33253: Turn off autocompletion for 2FA authentication code
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-16 19:57:29 UTC
Size:
1.79 KB
patch
obsolete
>From 8fd460c454e1a4c7d900f84a0ed4573d19e5bda0 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 16 Apr 2023 10:45:06 +0000 >Subject: [PATCH] Bug 33253: Turn off autocompletion for 2FA authentication > code > >The form for entering your authentication code shoudl not suggest >previous codes. > >To test: >* Activate TwoFactorAuthentication >* Go to your patron account in staff >* More > Manage 2-factor authentication >* I used "Google authenticator" on my phone, so: >* Open app on your phone, add new and scan the QR code >* Enter activation code >* Log out of staff interface >* Log back in, you are now also asked for an authentication code > as second step >* Look up code in app, enter, get logged in >* Log out, log back in - the form now suggests the previous code > when you click on it >* Apply patch >* Reload things (restart_all on ktd) >* Verify that you no longer get the suggestion > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >index bee28f8274..23b70b29b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >@@ -175,7 +175,7 @@ > [% END %] > [% END %] > [% ELSIF TwoFA_prompt %] >- <form action="[% script_name | html %]" method="post" name="loginform" id="loginform"> >+ <form action="[% script_name | html %]" method="post" name="loginform" id="loginform" autocomplete="off"> > <input type="hidden" name="koha_login_context" value="intranet" /> > [% FOREACH INPUT IN INPUTS %] > <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" /> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33253
:
149725
|
149733
|
150210