Bugzilla – Attachment 150092 Details for
Bug 32875
Fix cataloguing/value_builder/unimarc_leader_authorities.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl
Bug-32875-Fix-cataloguingvaluebuilderunimarcleader.patch (text/plain), 2.10 KB, created by
Katrin Fischer
on 2023-04-22 21:02:27 UTC
(
hide
)
Description:
Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-22 21:02:27 UTC
Size:
2.10 KB
patch
obsolete
>From 2f9888c5a70cf12fc363c13161b192970ce88816 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:55 +0100 >Subject: [PATCH] Bug 32875: Fix > cataloguing/value_builder/unimarc_leader_authorities.pl > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > cataloguing/value_builder/unimarc_leader_authorities.pl | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_leader_authorities.pl b/cataloguing/value_builder/unimarc_leader_authorities.pl >index 365a44ddbb..11b0a0b4db 100755 >--- a/cataloguing/value_builder/unimarc_leader_authorities.pl >+++ b/cataloguing/value_builder/unimarc_leader_authorities.pl >@@ -30,15 +30,16 @@ sub plugin_javascript { > my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script type='text/javascript'> >- function Clic$field_number(i) { >+ function Clic$field_number(event) { >+ event.preventDefault(); > var defaultvalue; > try { >- defaultvalue = document.getElementById(i).value; >+ defaultvalue = document.getElementById(event.data.id).value; > } catch(e) { >- alert('error when getting '+i); >+ alert('error when getting '+event.data.id); > return; > } >- window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader_authorities.pl&index=\"+i+\"&result=\"+defaultvalue,\"unimarc_field_000\",'width=1000,height=600,toolbar=false,scrollbars=yes'); >+ window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader_authorities.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_000\",'width=1000,height=600,toolbar=false,scrollbars=yes'); > } > </script> > "; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32875
:
146141
|
146809
|
149006
| 150092