Bugzilla – Attachment 150111 Details for
Bug 32917
Change patron.firstname and patron.surname in password change sample notice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32917: Fix sample notice for CHANGE_PASSWORD
Bug-32917-Fix-sample-notice-for-CHANGEPASSWORD.patch (text/plain), 2.77 KB, created by
David Nind
on 2023-04-22 23:42:31 UTC
(
hide
)
Description:
Bug 32917: Fix sample notice for CHANGE_PASSWORD
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-22 23:42:31 UTC
Size:
2.77 KB
patch
obsolete
>From 9869900e7881a92e55ad0e1fe37f564d47183d67 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 16 Apr 2023 12:19:40 +0000 >Subject: [PATCH] Bug 32917: Fix sample notice for CHANGE_PASSWORD > >We've identified 3 issues: >* Name of patron is not showing up in subject line >* Name of patron is now showing in notice text >* Notice is set to be HTML, but has no line breaks and uses no HTML tags > >In the database update, these issues don't occur: > >$dbh->do( q{ > INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification', > "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email'); >}); > >So this patch will make them match up: > >* Remove HTML flag >* Update patron. to borrower. in message text >* Remove patron name from subject (it won't work even with the correct variables) > >To test: >* Add an email address to your favourite sample user >* Make sure NotifyPasswordChange is set to "Notify" >* Update the sample user's password using the "change password" feature >* Verify a notice is shown in the notices tabs > Note: you won't see the line break issue there because of bug 30287 >* Apply patch >* Recreate your database/run web installer so sample notices are loaded >* Repeat the test, it should generate a nice lookig notice now > >Signed-off-by: David Nind <david@davidnind.com> >--- > installer/data/mysql/en/mandatory/sample_notices.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index e73f6b8167..fd4ed6768f 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1321,12 +1321,12 @@ tables: > code: PASSWORD_CHANGE > branchcode: "" > name: "Notification of password change" >- is_html: 1 >- title: "Library account password change notification for [% patron.firstname %] [% patron.surname %]" >+ is_html: 0 >+ title: "Library account password change notification" > message_transport_type: email > lang: default > content: >- - "Dear [% patron.firstname %] [% patron.surname %]," >+ - "Dear [% borrower.firstname %] [% borrower.surname %]," > - "" > - "We want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff." > - "" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32917
:
149729
|
150111
|
150207