Bugzilla – Attachment 150193 Details for
Bug 33156
Batch patron modification tool is missing search bar and other attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33156: Fix JS error on batch patron modification
Bug-33156-Fix-JS-error-on-batch-patron-modificatio.patch (text/plain), 2.42 KB, created by
Jonathan Druart
on 2023-04-25 12:29:23 UTC
(
hide
)
Description:
Bug 33156: Fix JS error on batch patron modification
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-04-25 12:29:23 UTC
Size:
2.42 KB
patch
obsolete
>From 451e0f4ec4b721740f54364126b42b94d73d57b8 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 19 Mar 2023 22:06:12 +0000 >Subject: [PATCH] Bug 33156: Fix JS error on batch patron modification > >The error currently breaks some of the functionality for >updating patron attributes linked to AV values. With the >bug, the input field will not change to the AV list when selected >from the pull down of patron attributes. > >It was probably bug 29648 that changed the data structure >without adapting for the additional data that is pushed >to the object for the patron attribute columns. > >To test: >* Create several extended patron attributes > * Make sure at least one is linked to an AV > * Repeatable and unique patron attributes can't be > updated in batch patron modification, so you need some > that can be modified. >* Go to tools > batch patron modification >* Enter one or more cardnumbers to update >* Verify the table is missing columns, export and configure >* Verify when selecting the AV tied patron attribute, the input > remains a text one >* Apply patch >* Both should work now as expected > >Note: I believe there are some more errors on this page, >but they should better be handled separately. So with this >patch we push configuration again for each column to table >columns, but the very last column keeps missing from the >columns settings. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index fdd054868ac..c387852d3fb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -418,8 +418,9 @@ > var patron_attributes_lib = new Array(); > var patron_attributes_values = new Array(); > var table_settings = [% TablesSettings.GetTableSettings( 'tools', 'batch_patron_modification', 'borrowerst', 'json' ) | $raw %]; >+ > [% FOREACH attrh IN attributes_header %] >- table_settings.push({ >+ table_settings["columns"].push({ > columname: "[% attrh.attribute | html %]", > cannot_be_modified: 0, > cannot_be_toggled: 0, >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33156
:
148406
|
149074
| 150193