View | Details | Raw Unified | Return to bug 28844
Collapse All | Expand All

(-)a/C4/Suggestions.pm (-26 lines)
Lines 35-41 our @EXPORT = qw( Link Here
35
  DelSuggestion
35
  DelSuggestion
36
  GetSuggestion
36
  GetSuggestion
37
  GetSuggestionByStatus
37
  GetSuggestionByStatus
38
  GetSuggestionFromBiblionumber
39
  GetSuggestionInfo
38
  GetSuggestionInfo
40
  ModStatus
39
  ModStatus
41
  ModSuggestion
40
  ModSuggestion
Lines 94-124 sub GetSuggestion { Link Here
94
    return ( $sth->fetchrow_hashref );
93
    return ( $sth->fetchrow_hashref );
95
}
94
}
96
95
97
=head2 GetSuggestionFromBiblionumber
98
99
$ordernumber = &GetSuggestionFromBiblionumber($biblionumber)
100
101
Get a suggestion from it's biblionumber.
102
103
return :
104
the id of the suggestion which is related to the biblionumber given on input args.
105
106
=cut
107
108
sub GetSuggestionFromBiblionumber {
109
    my ($biblionumber) = @_;
110
    my $query = q{
111
        SELECT suggestionid
112
        FROM   suggestions
113
        WHERE  biblionumber=? LIMIT 1
114
    };
115
    my $dbh = C4::Context->dbh;
116
    my $sth = $dbh->prepare($query);
117
    $sth->execute($biblionumber);
118
    my ($suggestionid) = $sth->fetchrow;
119
    return $suggestionid;
120
}
121
122
=head2 GetSuggestionInfo
96
=head2 GetSuggestionInfo
123
97
124
Get a suggestion and borrower's informations from it's suggestionid
98
Get a suggestion and borrower's informations from it's suggestionid
(-)a/t/db_dependent/Suggestions.t (-8 / +2 lines)
Lines 18-24 Link Here
18
use Modern::Perl;
18
use Modern::Perl;
19
19
20
use DateTime::Duration;
20
use DateTime::Duration;
21
use Test::More tests => 79;
21
use Test::More tests => 76;
22
use Test::Warn;
22
use Test::Warn;
23
23
24
use t::lib::Mocks;
24
use t::lib::Mocks;
Lines 34-40 use Koha::Patrons; Link Here
34
use Koha::Suggestions;
34
use Koha::Suggestions;
35
35
36
BEGIN {
36
BEGIN {
37
    use_ok('C4::Suggestions', qw( NewSuggestion GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionFromBiblionumber GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ));
37
    use_ok('C4::Suggestions', qw( NewSuggestion GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ));
38
}
38
}
39
39
40
my $schema  = Koha::Database->new->schema;
40
my $schema  = Koha::Database->new->schema;
Lines 284-294 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInf Link Here
284
is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
284
is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
285
285
286
286
287
is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' );
288
is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' );
289
is( GetSuggestionFromBiblionumber($biblio_1->biblionumber), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' );
290
291
292
my $suggestions = GetSuggestionByStatus();
287
my $suggestions = GetSuggestionByStatus();
293
is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
288
is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
294
$suggestions = GetSuggestionByStatus('CHECKED');
289
$suggestions = GetSuggestionByStatus('CHECKED');
295
- 

Return to bug 28844