Bugzilla – Attachment 151975 Details for
Bug 33247
Deleted authority still on results list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33247: (QA follow-up) Remove pending deletion from results array
Bug-33247-QA-follow-up-Remove-pending-deletion-fro.patch (text/plain), 2.20 KB, created by
Marcel de Rooy
on 2023-06-02 08:39:57 UTC
(
hide
)
Description:
Bug 33247: (QA follow-up) Remove pending deletion from results array
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-06-02 08:39:57 UTC
Size:
2.20 KB
patch
obsolete
>From 47e1d9c887da12b4bcbbdda2295f9ff6f110e61a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 2 Jun 2023 08:17:45 +0000 >Subject: [PATCH] Bug 33247: (QA follow-up) Remove pending deletion from > results array >Content-Type: text/plain; charset=utf-8 > >Both Elastic and Zebra search_auth_compat return a hash key >authid for a result. > >Test plan: >Remove an authority that should be in your results list. >Note that it is no longer marked as pending, but just not displayed. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > authorities/authorities-home.pl | 5 ++++- > .../prog/en/modules/authorities/searchresultlist.tt | 1 - > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl >index 5b4ab19bd7..e4f9bc471d 100755 >--- a/authorities/authorities-home.pl >+++ b/authorities/authorities-home.pl >@@ -201,6 +201,10 @@ if ( $op eq "do_search" ) { > } > } > >+ if( $pending_deletion_authid && $results ) { >+ $results = [ grep { $_->{authid} != $pending_deletion_authid } @$results ]; >+ } >+ > $template->param( result => $results ) if $results; > > my $max_result_window = $searcher->max_result_window; >@@ -241,7 +245,6 @@ my $servers = Koha::Z3950Servers->search( > $template->param( > servers => $servers, > authority_types => $authority_types, >- pending_deletion_authid => $pending_deletion_authid, > op => $op, > ); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >index 22cbd559b6..42826d7928 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >@@ -73,7 +73,6 @@ > [% ELSE %] > [% PROCESS authresult summary=resul.summary authid=resul.authid %] > [% END %] >- [% IF pending_deletion_authid == resul.authid %]<span style="color: red;">Pending deletion</span>[% END %] > </td> > <td>[% resul.authtype | html %]</td> > [% UNLESS ( resul.isEDITORS ) %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33247
:
151070
|
151162
|
151974
| 151975