Bugzilla – Attachment 15214 Details for
Bug 9584
Remove problematic IE CSS Hacks in staff client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9584 - Remove problematic IE CSS Hacks in staff client
0001-Bug-9584-Remove-problematic-IE-CSS-Hacks-in-staff-cl.patch (text/plain), 2.54 KB, created by
David Cook
on 2013-02-11 03:38:19 UTC
(
hide
)
Description:
Bug 9584 - Remove problematic IE CSS Hacks in staff client
Filename:
MIME Type:
Creator:
David Cook
Created:
2013-02-11 03:38:19 UTC
Size:
2.54 KB
patch
obsolete
>From cbad40c2136f290c636c14119058e757b30c09b8 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 11 Feb 2013 14:27:48 +1100 >Subject: [PATCH] Bug 9584 - Remove problematic IE CSS Hacks in staff client > >Currently, there are several CSS rules, which are hacks for IE versions 7 and older, in staff-global.css. > >Within these, the hidden overflow property for *HTML BODY is cutting off lengthy content in search results, managing labels, etc. This prevents users from seeing the full pages of results, and prevents them from paging over for more results. > >While we might not want to support older versions of IE, this is problematic behaviour, and it shouldn't be happening. I'm not sure of the origin of these hacks, but it looks like we should remove them. When they are removed, the search results, label results, etc. display properly as they should. > >--- > >To test: > >Before applying patch... > >1) Open up Internet Explorer 6 or a newer version of Internet Explorer and use the F12 Developer Tools to change the Document Mode to Quirks Mode >2) Conduct a search on the staff client that will generate a high number of hits. (e.g. "e" as an unlimited query, if you have a maximum of a few thousand records.) >3) Note that you can't access the page options at the bottom of the page and that your result list is cut off at the bottom, and thus inaccessible. > >Apply patch... > >4) Refresh your browser (preferably using F5 or whatever other method you use to bypass the browser's cache), and re-run the search if necessary >5) Note that you are now able to see the full page of search results, plus the paging at the bottom > >As far as I can tell, there are no regressions, but feel free to search for them. Afaik, there are no doc1 or doc2 ids, and I can't see any problems with any elements with doc3 IDs. >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 19 ------------------- > 1 files changed, 0 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index 1a3e563..8046027 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -1718,25 +1718,6 @@ div.lang { > position: fixed; > } > } >- >- * html body{ >- overflow:hidden; >- } >- >- * html div#doc1{ >- height:100%; >- overflow:auto; >- } >- >- * html div#doc2{ >- height:100%; >- overflow:auto; >- } >- >- * html div#doc3{ >- height:100%; >- overflow:auto; >- } > > #CheckAll, #CheckNone, #CheckPending { > font-weight : normal; >-- >1.7.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9584
: 15214