Bugzilla – Attachment 152430 Details for
Bug 33971
Remove support for x-koha-query header
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33971: Remove x-koha-query handing in Orders.pm
Bug-33971-Remove-x-koha-query-handing-in-Orderspm.patch (text/plain), 1.73 KB, created by
Jonathan Druart
on 2023-06-16 15:37:37 UTC
(
hide
)
Description:
Bug 33971: Remove x-koha-query handing in Orders.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-06-16 15:37:37 UTC
Size:
1.73 KB
patch
obsolete
>From f41e11166f5f9014f4138f0c42a40a81cf6b86c2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 13 Jun 2023 10:48:14 -0300 >Subject: [PATCH] Bug 33971: Remove x-koha-query handing in Orders.pm > >This patch removes manual handling of `x-koha-query` in the >Orders:list() controller. > >There are no tests for the feature but you can verify no behavior is >changed by doing: > >1. Run: > $ ktd --shell > k$ prove t/db_dependent/api/v1/acquisitions_orders.t >=> SUCCESS: Tests pass >2. Apply this patch >3. Repeat 1 >=> SUCCESS: Tests pass >4. Sign off :-D > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/REST/V1/Acquisitions/Orders.pm | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/Koha/REST/V1/Acquisitions/Orders.pm b/Koha/REST/V1/Acquisitions/Orders.pm >index bb12ed0a536..d0bdb40fd29 100644 >--- a/Koha/REST/V1/Acquisitions/Orders.pm >+++ b/Koha/REST/V1/Acquisitions/Orders.pm >@@ -133,8 +133,7 @@ sub list { > } > > if ( defined $reserved_params->{q} >- || defined $reserved_params->{query} >- || defined $reserved_params->{'x-koha-query'} ) >+ || defined $reserved_params->{query} ) > { > > $filtered_params //={}; >@@ -151,12 +150,6 @@ sub list { > if $q; # skip if exists but is empty > } > >- # x-koha-query contains a string >- push @query_params_array, >- $json->decode( >- $c->table_name_fixer( $reserved_params->{'x-koha-query'} ) ) >- if $reserved_params->{'x-koha-query'}; >- > # query is already decoded by JSON::Validator at this point > push @query_params_array, > $json->decode( >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33971
:
152302
|
152303
|
152304
|
152422
|
152429
|
152430
|
152431
|
152690
|
152691
|
152692