From 10b3fc95b768e6d0562bba076ebaee9a19364d52 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Tue, 4 Jul 2023 09:45:26 +0200 Subject: [PATCH] Bug 27880: Minor optimizations for Koha::Migrations::pending_migrations Can save a few milliseconds when there are a lot (> 1000) of migration files --- Koha/Migrations.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Koha/Migrations.pm b/Koha/Migrations.pm index a4a6782d52..69ef70854b 100644 --- a/Koha/Migrations.pm +++ b/Koha/Migrations.pm @@ -12,17 +12,19 @@ sub pending_migrations { my @pending_migrations; my $executed_migrations = {}; eval { - $executed_migrations = $dbh->selectall_hashref('SELECT * FROM executed_migrations', 'name'); + $executed_migrations = $dbh->selectall_hashref('SELECT name FROM executed_migrations', 'name'); }; opendir(my $dh, $self->migrations_dir); - foreach my $file (sort readdir $dh) { + foreach my $file (readdir $dh) { next if $file !~ /\.pl$/; next if (exists ($executed_migrations->{$file})); push @pending_migrations, $file; } closedir($dh); + @pending_migrations = sort @pending_migrations; + return @pending_migrations; } -- 2.30.2