Bugzilla – Attachment 15327 Details for
Bug 9192
UNIMARC_sync_date_created_with_marc_biblio.pl field creation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch (follow-up 1)
0002-Bug-9192-UNIMARC_sync_date_created_with_marc_biblio..patch (text/plain), 2.06 KB, created by
Fridolin Somers
on 2013-02-14 16:23:43 UTC
(
hide
)
Description:
Proposed patch (follow-up 1)
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2013-02-14 16:23:43 UTC
Size:
2.06 KB
patch
obsolete
>From 914d83cc9157d2ec63158a6abde80e1216b04c89 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Thu, 14 Feb 2013 17:20:45 +0100 >Subject: [PATCH 2/2] Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl > field creation (followup) > >Add tests : >if field < 10 it must not have a subfield >if field > 9 is must have a subfield >--- > misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl b/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl >index b5c78e5..ce075cc 100755 >--- a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl >+++ b/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl >@@ -52,6 +52,10 @@ $verbose and print "================================\n"; > $date_created_marc = '099c' unless $date_created_marc; > my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc); > die "date-created-marc '$date_created_marc' is not correct." unless $c_field; >+die "date-created-marc field is greated that 009, it should have a subfield." >+ if ( $c_field > 9 && !defined $c_subfield ); >+die "date-created-marc field is lower that 010, it should not have a subfield." >+ if ( $c_field < 10 && defined $c_subfield ); > if ($verbose) { > print "Date created on $c_field"; > print $c_subfield if defined $c_subfield; # use of defined to allow 0 >@@ -62,6 +66,10 @@ if ($verbose) { > $date_modified_marc = '099d' unless $date_modified_marc; > my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc); > die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field; >+die "date-modified-marc field is greated that 009, it should have a subfield." >+ if ( $m_field > 9 && !defined $m_subfield ); >+die "date-modified-marc field is lower that 010, it should not have a subfield." >+ if ( $m_field < 10 && defined $m_subfield ); > die > "When date-created-marc and date-modified-marc are on same field, they should have distinct subfields" > if ( $c_field eq $m_field ) >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9192
:
13840
|
14281
|
14939
|
15327
|
20866
|
20867
|
22173