View | Details | Raw Unified | Return to bug 33745
Collapse All | Expand All

(-)a/t/00-testcritic.t (-2 / +5 lines)
Lines 9-17 use English qw(-no_match_vars); Link Here
9
eval { require Test::Perl::Critic; };
9
eval { require Test::Perl::Critic; };
10
10
11
if ( $EVAL_ERROR ) {
11
if ( $EVAL_ERROR ) {
12
    my $msg = 'Test::Perl::Critic required to criticise code,';
12
    my $msg = 'Test::Perl::Critic required to criticise code';
13
    plan( skip_all => $msg );
13
    plan( skip_all => $msg );
14
}
14
}
15
15
16
Test::Perl::Critic->import( -profile => '.perlcriticrc');
16
Test::Perl::Critic->import( -profile => '.perlcriticrc');
17
all_critic_ok('.');
17
# Test all perl files excluding Koha/Object.pm, see t/00-testcritic_2.t
18
my $koha_object_module = ( -e 'Koha/Object.pm' ? '' : 'lib/' ) . 'Koha/Object.pm';
19
my @files = grep { $_ ne $koha_object_module } Perl::Critic::Utils::all_perl_files('.');
20
all_critic_ok( @files );
(-)a/t/00-testcritic_2.t (-1 / +16 lines)
Line 0 Link Here
0
- 
1
#!/usr/bin/env perl
2
3
# Running perlcritic on specific Koha files (as exception)
4
5
use Modern::Perl;
6
use Test::More tests => 2;
7
use English qw(-no_match_vars);
8
9
SKIP: {
10
    eval { require Perl::Critic; };
11
    skip 'Perl::Critic required to criticise code', 2 if $EVAL_ERROR;
12
    my $file = ( -e 'Koha/Object.pm' ? '' : 'lib/' ) . 'Koha/Object.pm';
13
    my @violations = Perl::Critic->new( -profile => '.perlcriticrc' )->critique($file);
14
    is( @violations, 1, "One violation found in $file" );
15
    like( $violations[0], qr/Stricture disabled at line/, 'No strict refs found as expected' );
16
}

Return to bug 33745