From 24f2ff59a8c07288f4ab993aa03b1e7ab3e2d38b Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Mon, 14 Aug 2023 15:15:44 +0000 Subject: [PATCH] Bug 30846: (Fix) Unit tests --- t/db_dependent/Reserves.t | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index e1d69ffce0..7e2d83e50e 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -1484,10 +1484,20 @@ subtest 'IsAvailableForItemLevelRequest() tests' => sub { "Item not available for item-level hold because no effective item type" ); - my $item_1 = $builder->build_sample_item({ notforloan => -1 }); + Koha::CirculationRules->set_rules( + { + categorycode => '*', + itemtype => '*', + branchcode => '*', + rules => { + onshelfholds => 0, + } + } + ); + my $item_1 = $builder->build_sample_item( { notforloan => -1 } ); ok( C4::Reserves::IsAvailableForItemLevelRequest( $item_1, $patron ), - "Item not available for item-level hold because no effective item type" + "We can placing hold on item with negative not for loan values when 'On shelf holds allowed' is set to 'If any unavailable'" ); $schema->storage->txn_rollback; }; -- 2.34.1