From d548e1731908d2c8687ab923ba56823714111548 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 6 Jun 2023 15:20:38 +0000 Subject: [PATCH] Bug 33918: Improve translation of title tags: Patron card creator This patch updates patron card creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Tools -> Patron card creator home page - New -> Card batch - New -> Image - New -> Layout - New -> Card template - New -> Printer profile - Manage -> Card batches - Manage -> Images - Manage -> Layouts - Manage -> Card templates - Manage -> Printer profiles --- .../prog/en/modules/patroncards/edit-batch.tt | 15 ++++++++-- .../en/modules/patroncards/edit-layout.tt | 29 +++++++++++++----- .../en/modules/patroncards/edit-profile.tt | 22 ++++++++++---- .../en/modules/patroncards/edit-template.tt | 19 +++++++++--- .../prog/en/modules/patroncards/home.tt | 7 ++++- .../en/modules/patroncards/image-manage.tt | 10 +++++-- .../prog/en/modules/patroncards/manage.tt | 30 ++++++++++++------- .../prog/en/modules/patroncards/print.tt | 9 +++++- 8 files changed, 106 insertions(+), 35 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index 49810c17ee..524f5a1301 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -1,8 +1,19 @@ [% USE raw %] [% USE Asset %] +[% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] - [% IF batch_id %]Edit ([% batch_id | html %])[% ELSE %]New[% END %] › Batches › Patron card creator › Tools › Koha + [% FILTER collapse %] + [% IF ( batch_id ) %] + [% t("Edit patron card batch") | html %] ([% batch_id | html %]) + [% ELSE %] + [% t("New patron card batch") | html %] + [% END %] › + [% t("Batches") | html %] › + [% t("Patron card creator") | html %] › + [% t("Tools") | html %] › + [% t("Koha") | html %] + [% END %] [% INCLUDE 'doc-head-close.inc' %] @@ -28,7 +39,7 @@ [% ELSIF batch_id %] Edit ([% batch_id | html %]) [% ELSE %] - New + New patron card batch [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt index 5ab532b15e..4f472779ff 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt @@ -1,7 +1,18 @@ [% USE raw %] +[% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] - [% IF ( layout_id ) %]Edit ([% layout_id | html %])[% ELSE %]New[% END %] › Layout › Patron card creator › Tools › Koha + [% FILTER collapse %] + [% IF( layout_id ) %] + [% t("Edit patron card layout") | html %] ([% layout_id | html %]) + [% ELSE %] + [% t("New patron card layout") | html %] + [% END %] › + [% t("Layout") | html %] › + [% t("Patron card creator") | html %] › + [% t("Tools") | html %] › + [% t("Koha") | html %] + [% END %] [% INCLUDE 'doc-head-close.inc' %] @@ -25,7 +36,7 @@ [% IF ( layout_id ) %] Edit ([% layout_id | html %]) [% ELSE %] - New + New patron card layout [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] @@ -38,8 +49,12 @@ [% INCLUDE 'patroncards-toolbar.inc' %] -

[% IF ( layout_id ) %]Edit patron card layout [% layout_id | html %] - [% ELSE %]Create patron card layout[% END %] +

+ [% IF ( layout_id ) %] + Edit patron card layout [% layout_id | html %] + [% ELSE %] + New patron card layout + [% END %]

@@ -47,7 +62,7 @@
- [% IF ( layout_id ) %]Edit[% ELSE %]Create[% END %] patron card text layout + Patron card text layout
  1. @@ -278,9 +293,7 @@
- [% IF ( layout_id ) %]Edit patron card graphic layout - [% ELSE %]Create patron card graphic layout[% END %] - + Patron card graphic layout
    + [% IF ( print ) %]
    - [% IF ( print ) %][% END %] +
    -
+ [% END %] + [% IF patron_lists %]
- Or use a patron list + Export by patron list
  1. @@ -125,7 +133,7 @@
- +
[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt index 41a2ebc31a..6bcd9993e2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt @@ -1,7 +1,14 @@ +[% USE raw %] [% USE Asset %] +[% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] - Patron card printing/exporting › Patron cards › Tools › Koha + [% FILTER collapse %] + [% t("Patron card printing/exporting") | html %] › + [% t("Patron cards") | html %] › + [% t("Tools") | html %] › + [% t("Koha") | html %] + [% END %] [% INCLUDE 'doc-head-close.inc' popup => 1%] -- 2.30.2