Bugzilla – Attachment 154714 Details for
Bug 33716
ILL - Allow for a disclaimer stage per request type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid
Bug-33716-QA-follow-up-Fix-submission-when-cardnum.patch (text/plain), 1.42 KB, created by
Pedro Amorim
on 2023-08-23 15:25:39 UTC
(
hide
)
Description:
Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-08-23 15:25:39 UTC
Size:
1.42 KB
patch
obsolete
>From d67ef3283cc9f72791081746fee3f3d67682f793 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 23 Aug 2023 15:24:49 +0000 >Subject: [PATCH] Bug 33716: (QA follow-up) Fix submission when cardnumber is > invalid > >Issue that this patch fixes: >1) Enable ILLmodule and install FreeForm, run: >bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) >2) Copy the example YAML text into the system preference input box >3) Create a new FreeForm request and enter a duff borrowernumber e.g. '11111111111111' >4) Click 'Create'. Submit the type disclaimer stage. >5) Notice there's an error >6) Apply this patch. >7) Repeat steps 3 and 4. Verify that the correct 'The borrower details you entered are invalid' error message is displayed instead of the error in 5). >--- > ill/ill-requests.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index 189d904a29..91160693b4 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -131,7 +131,7 @@ if ( $backends_available ) { > my $backend_result = $request->backend_create($params); > > # After creation actions >- if ( $params->{type_disclaimer_submitted} ) { >+ if ( $params->{type_disclaimer_submitted} && $request->illrequest_id ) { > $type_disclaimer->after_request_created($params, $request); > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33716
:
151027
|
151031
|
151032
|
151033
|
151034
|
151035
|
151146
|
151147
|
151148
|
151149
|
151150
|
151388
|
151389
|
151390
|
151391
|
151392
|
151393
|
151394
|
151401
|
151402
|
151403
|
151404
|
151405
|
151406
|
151407
|
151408
|
151409
|
151410
|
151411
|
152809
|
152810
|
152811
|
152813
|
152814
|
152815
|
152816
|
152817
|
152818
|
152819
|
152820
|
152821
|
152822
|
152823
|
152826
|
154305
|
154454
| 154714