View | Details | Raw Unified | Return to bug 34767
Collapse All | Expand All

(-)a/C4/SIP/ILS.pm (-1 / +6 lines)
Lines 469-475 sub renew { Link Here
469
469
470
    $trans = C4::SIP::ILS::Transaction::Renew->new();
470
    $trans = C4::SIP::ILS::Transaction::Renew->new();
471
    $trans->patron($patron = C4::SIP::ILS::Patron->new( $patron_id ));
471
    $trans->patron($patron = C4::SIP::ILS::Patron->new( $patron_id ));
472
473
    if (!$patron) {
472
    if (!$patron) {
474
		$trans->screen_msg("Invalid patron barcode.");
473
		$trans->screen_msg("Invalid patron barcode.");
475
		return $trans;
474
		return $trans;
Lines 505-510 sub renew { Link Here
505
    # }
504
    # }
506
505
507
    $trans->item($item);
506
    $trans->item($item);
507
    if ($fee_ack) {
508
        $trans->fee_ack($fee_ack);
509
    }
508
510
509
    if (!defined($item)) {
511
    if (!defined($item)) {
510
		$trans->screen_msg("Item not checked out to " . $patron->name);     # not checked out to $patron_id
512
		$trans->screen_msg("Item not checked out to " . $patron->name);     # not checked out to $patron_id
Lines 526-531 sub renew_all { Link Here
526
    my $trans;
528
    my $trans;
527
529
528
    $trans = C4::SIP::ILS::Transaction::RenewAll->new();
530
    $trans = C4::SIP::ILS::Transaction::RenewAll->new();
531
    if ($fee_ack) {
532
        $trans->fee_ack($fee_ack);
533
    }
529
534
530
    $trans->patron($patron = C4::SIP::ILS::Patron->new( $patron_id ));
535
    $trans->patron($patron = C4::SIP::ILS::Patron->new( $patron_id ));
531
    if (defined $patron) {
536
    if (defined $patron) {
(-)a/C4/SIP/ILS/Transaction/Renew.pm (+2 lines)
Lines 6-11 package C4::SIP::ILS::Transaction::Renew; Link Here
6
6
7
use warnings;
7
use warnings;
8
use strict;
8
use strict;
9
use C4::SIP::Sip qw( siplog );
9
10
10
use C4::Circulation qw( CanBookBeRenewed GetIssuingCharges AddIssue );
11
use C4::Circulation qw( CanBookBeRenewed GetIssuingCharges AddIssue );
11
use Koha::Patrons;
12
use Koha::Patrons;
Lines 64-69 sub do_renew_for { Link Here
64
65
65
sub do_renew {
66
sub do_renew {
66
    my $self = shift;
67
    my $self = shift;
68
	siplog('LOG_DEBUG', "ILS::Transaction::Renew performing renewal...");
67
    my $patron = Koha::Patrons->find( $self->{patron}->borrowernumber );
69
    my $patron = Koha::Patrons->find( $self->{patron}->borrowernumber );
68
    $patron or return; # FIXME we should log that
70
    $patron or return; # FIXME we should log that
69
    return $self->do_renew_for($patron);
71
    return $self->do_renew_for($patron);
(-)a/C4/SIP/ILS/Transaction/RenewAll.pm (-1 / +1 lines)
Lines 33-38 sub new { Link Here
33
33
34
sub do_renew_all {
34
sub do_renew_all {
35
    my $self     = shift;
35
    my $self     = shift;
36
	siplog('LOG_DEBUG', "ILS::Transaction::RenewAll performing renewals...");
36
    my $patron = Koha::Patrons->find( $self->{patron}->{borrowernumber} );
37
    my $patron = Koha::Patrons->find( $self->{patron}->{borrowernumber} );
37
    my $all_ok   = 1;
38
    my $all_ok   = 1;
38
    $self->{renewed}   = [];
39
    $self->{renewed}   = [];
39
- 

Return to bug 34767