Bugzilla – Attachment 155680 Details for
Bug 26314
"Volumes: show volumes" showing regardless of whether there are volumes linked to the record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26314: (QA follow-up) Resolve new QA script failures
Bug-26314-QA-follow-up-Resolve-new-QA-script-failu.patch (text/plain), 1.83 KB, created by
Katrin Fischer
on 2023-09-15 14:07:38 UTC
(
hide
)
Description:
Bug 26314: (QA follow-up) Resolve new QA script failures
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-15 14:07:38 UTC
Size:
1.83 KB
patch
obsolete
>From d86bcd0bedf7886147b9b9010824de22ba30c632 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 8 Sep 2023 15:36:20 +0100 >Subject: [PATCH] Bug 26314: (QA follow-up) Resolve new QA script failures > >Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > catalogue/detail.pl | 2 +- > opac/opac-detail.pl | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index 085be435b8..428574e365 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -270,7 +270,7 @@ if ( $showcomp eq 'both' || $showcomp eq 'staff' ) { > } > > # Display volumes link >-my $show_volumes = 1 if @{$biblio->get_marc_volumes(1)}; >+my $show_volumes = @{ $biblio->get_marc_volumes(1) } ? 1 : 0; > > # XSLT processing of some stuff > my $xslt_variables = { >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 620ceb4945..b9c644e38d 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -621,7 +621,7 @@ if ( $showcomp eq 'both' || $showcomp eq 'opac' ) { > } > > # Display volumes link >-my $show_volumes = 1 if @{$biblio->get_marc_volumes(1)}; >+my $show_volumes = @{ $biblio->get_marc_volumes(1) } ? 1 : 0; > > # XSLT processing of some stuff > my $variables = {}; >@@ -637,9 +637,9 @@ my @plugin_responses = Koha::Plugins->call( > for my $plugin_variables ( @plugin_responses ) { > $variables = { %$variables, %$plugin_variables }; > } >-$variables->{anonymous_session} = $borrowernumber ? 0 : 1; >+$variables->{anonymous_session} = $borrowernumber ? 0 : 1; > $variables->{show_analytics_link} = $show_analytics; >-$variables->{show_volumes_link} = $show_volumes; >+$variables->{show_volumes_link} = $show_volumes; > $template->param( > XSLTBloc => XSLTParse4Display({ > biblionumber => $biblionumber, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26314
:
123615
|
124367
|
124380
|
124381
|
126448
|
126449
|
126450
|
126952
|
126953
|
126954
|
126955
|
155437
|
155438
|
155439
|
155440
|
155441
|
155446
|
155447
|
155448
|
155449
|
155450
|
155670
|
155671
|
155672
|
155673
|
155674
|
155675
|
155676
|
155677
|
155678
|
155679
| 155680 |
155681
|
162163
|
162164