From c3f7bbcd61e3e538ffaba03c951a51e8e7ec6470 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 1 Nov 2023 15:37:54 +0000 Subject: [PATCH] Bug 35216: Rename question to needsconfirmation --- circ/circulation.pl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index d68eb1ce5f8..2913dfd47b1 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -299,9 +299,9 @@ if (@$barcodes) { }; # always check for blockers on issuing - my ( $error, $question, $alerts, $messages ); + my ( $error, $needsconfirmation, $alerts, $messages ); try { - ( $error, $question, $alerts, $messages ) = CanBookBeIssued( + ( $error, $needsconfirmation, $alerts, $messages ) = CanBookBeIssued( $patron, $barcode, $datedue, $inprocess, @@ -378,7 +378,7 @@ if (@$barcodes) { } } - delete $question->{'DEBT'} if ($debt_confirmed); + delete $needsconfirmation->{'DEBT'} if ($debt_confirmed); if( $item and ( !$blocker or $force_allow_issue ) ){ my $confirm_required = 0; @@ -391,8 +391,8 @@ if (@$barcodes) { $template_params->{itemhomebranch} = $item->homebranch; # pass needsconfirmation to template if issuing is possible and user hasn't yet confirmed. - foreach my $needsconfirmation ( keys %$question ) { - $template_params->{$needsconfirmation} = $$question{$needsconfirmation}; + foreach my $needsconfirmation ( keys %$needsconfirmation ) { + $template_params->{$needsconfirmation} = $$needsconfirmation{$needsconfirmation}; $template_params->{getTitleMessageIteminfo} = $biblio->title; $template_params->{getBarcodeMessageIteminfo} = $item->barcode; $template_params->{NEEDSCONFIRMATION} = 1; @@ -420,10 +420,10 @@ if (@$barcodes) { } } - if ($question->{RESERVE_WAITING} or $question->{RESERVED} or $question->{TRANSFERRED} or $question->{PROCESSING}){ + if ($needsconfirmation->{RESERVE_WAITING} or $needsconfirmation->{RESERVED} or $needsconfirmation->{TRANSFERRED} or $needsconfirmation->{PROCESSING}){ $template->param( - reserveborrowernumber => $question->{'resborrowernumber'}, - reserve_id => $question->{reserve_id}, + reserveborrowernumber => $needsconfirmation->{'resborrowernumber'}, + reserve_id => $needsconfirmation->{reserve_id}, ); } -- 2.30.2