Bugzilla – Attachment 158464 Details for
Bug 27992
When recording local use with statistical patron items are not checked in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27992: (QA follow-up) Perltidy
Bug-27992-QA-follow-up-Perltidy.patch (text/plain), 2.78 KB, created by
Katrin Fischer
on 2023-11-05 12:41:08 UTC
(
hide
)
Description:
Bug 27992: (QA follow-up) Perltidy
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-05 12:41:08 UTC
Size:
2.78 KB
patch
obsolete
>From 827103df07b9f454abd624c68db48dcf01b502e3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 5 Nov 2023 12:07:25 +0000 >Subject: [PATCH] Bug 27992: (QA follow-up) Perltidy > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Circulation.pm | 6 +++--- > t/db_dependent/Circulation.t | 12 ++++++------ > 2 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 7341efe42e..16a400711a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -827,9 +827,9 @@ sub CanBookBeIssued { > } > ); > my $block_lost_return = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0; >- my ( $stats_return, $stats_messages, $stats_iteminformation, $stats_borrower) = >- AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ); >- ModDateLastSeen( $item_object->itemnumber, $block_lost_return ); # FIXME Move to Koha::Item >+ my ( $stats_return, $stats_messages, $stats_iteminformation, $stats_borrower ) = >+ AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ); >+ ModDateLastSeen( $item_object->itemnumber, $block_lost_return ); # FIXME Move to Koha::Item > return ( > { > STATS => 1, >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index f64140defd..288c565013 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2474,17 +2474,17 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { > is( $stat->categorycode, $patron->categorycode, 'Recorded a categorycode' ); > is( $stat->location, $item_1->location, 'Recorded a location' ); > >- >- t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode }); >- my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); >+ t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode } ); >+ my $patron_2 = $builder->build_object( >+ { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); > my $item_2 = $builder->build_sample_item( { library => $library->branchcode } ); >- my $issue = AddIssue( $patron_2, $item_2->barcode ); >+ my $issue = AddIssue( $patron_2, $item_2->barcode ); > $item_2->discard_changes; >- ok($item_2->onloan, "Item is checked out"); >+ ok( $item_2->onloan, "Item is checked out" ); > > ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode ); > $item_2->discard_changes; >- ok(!$item_2->onloan, "Checked out item is returned"); >+ ok( !$item_2->onloan, "Checked out item is returned" ); > > # TODO There are other tests to provide here > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27992
:
126865
|
127189
|
128633
|
128634
|
146041
|
158011
|
158073
|
158086
|
158216
|
158217
|
158462
|
158463
| 158464 |
158465
|
158900