From b2a34a9ca4439cc38409c00f11f916dc3b4fa353 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 31 Oct 2023 13:33:19 -0400 Subject: [PATCH] Bug 34868: (QA follow-up) Rename new option, add comments --- C4/SIP/ILS/Item.pm | 3 ++- etc/SIPconfig.xml | 2 +- t/db_dependent/SIP/Transaction.t | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm index abd64fc216d..5ed37bdea56 100644 --- a/C4/SIP/ILS/Item.pm +++ b/C4/SIP/ILS/Item.pm @@ -264,7 +264,8 @@ sub sip_circulation_status { my $self = shift; my $server = shift; - my $missing_status = $server->{account}->{missing_lost_status}; + # Defines what lost status means "missing" for this SIP account + my $missing_status = $server->{account}->{lost_status_for_missing}; if ( $self->{_object}->get_transfer ) { return '10'; # in transit between libraries diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml index cdefb3f02df..69758edb88a 100644 --- a/etc/SIPconfig.xml +++ b/etc/SIPconfig.xml @@ -80,7 +80,7 @@ format_due_date="0" inhouse_item_types="" inhouse_patron_categories="" - missing_lost_status="4" + lost_status_for_missing="4" blocked_item_types="VM|MU" seen_on_item_information="mark_found"> diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t index 6bc02a62879..4fcdc76cd24 100755 --- a/t/db_dependent/SIP/Transaction.t +++ b/t/db_dependent/SIP/Transaction.t @@ -1116,7 +1116,7 @@ subtest item_circulation_status => sub { $sip_item = C4::SIP::ILS::Item->new( $item->barcode ); $status = $sip_item->sip_circulation_status; is( $status, '12', "Item circulation status is lost" ); - $status = $sip_item->sip_circulation_status( { account => { missing_lost_status => "1" } } ); + $status = $sip_item->sip_circulation_status( { account => { lost_status_for_missing => "1" } } ); is( $status, '13', "Item circulation status is missing" ); $item->itemlost(0)->store(); -- 2.30.2