From 0bcf89d23ca87a82544bd5138b525eef69973885 Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 9 Nov 2023 02:21:02 +0000 Subject: [PATCH] Bug 31199: Extend selenium timeout to account for Starman worker restart Previously, we've had a max retry of 10. If a try takes 1 second, then the 10 seconds it can take for a Starman worker to restart is enough to cause a test to fail if both workers are restarting at the same time. Test plan: 0. DO NOT apply the patch yet 1. Run prove -v ./t/db_dependent/selenium/patrons_search.t 2. When the output says "Subtest: filter by date of birth", run "koha-plack --reload kohadev" in a separate window 3. Note that the test fails 4. Run "reset_all" 5. Apply the patch 6. Run prove -v ./t/db_dependent/selenium/patrons_search.t 7. When the output says "Subtest: filter by date of birth", run "koha-plack --reload kohadev" in a separate window 8. Note that the test does not fail --- t/lib/Selenium.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm index 1117ce7762..3651444829 100644 --- a/t/lib/Selenium.pm +++ b/t/lib/Selenium.pm @@ -265,7 +265,7 @@ sub click_when_visible { $elt->click unless $clicked; # finally Raise the error } -sub max_retries { 10 } +sub max_retries { 20 } =head1 NAME -- 2.30.2