Bugzilla – Attachment 159340 Details for
Bug 32474
Implement infinite scroll in vue-select
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32474: Fix persistence of selections when pagination re-triggers
Bug-32474-Fix-persistence-of-selections-when-pagin.patch (text/plain), 1.85 KB, created by
Matt Blenkinsop
on 2023-11-29 14:56:42 UTC
(
hide
)
Description:
Bug 32474: Fix persistence of selections when pagination re-triggers
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-11-29 14:56:42 UTC
Size:
1.85 KB
patch
obsolete
>From 2f9828a662a91bcbd49e582df37b73fdb7a0a7d5 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 29 Nov 2023 14:54:33 +0000 >Subject: [PATCH] Bug 32474: Fix persistence of selections when pagination > re-triggers > >Currently when the select is closed and then re-opens, the pagination is re-triggered which removes the data that the lable is being pulled from for the select. This patch addresses this by keeping the currently selected piece of data and adding it into the re-paginated array of data. >--- > .../prog/js/vue/components/InfiniteScrollSelect.vue | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/InfiniteScrollSelect.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/InfiniteScrollSelect.vue >index 9dac42b808..0f7952a488 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/InfiniteScrollSelect.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/InfiniteScrollSelect.vue >@@ -76,6 +76,11 @@ export default { > }, > methods: { > async fetchInitialData(dataType) { >+ const currentSelection = this.modelValue >+ ? this.data.find( >+ item => this.modelValue === item[this.dataIdentifier] >+ ) >+ : null > const client = APIClient.erm > await client[dataType] > .getAll( >@@ -88,7 +93,9 @@ export default { > ) > .then( > items => { >- this.data = items >+ this.data = currentSelection >+ ? [currentSelection, ...items] >+ : items > this.search = "" > this.limit = 19 > this.scrollPage = 1 >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32474
:
144614
|
144719
|
144720
|
145143
|
145144
|
145154
|
150030
|
150031
|
150282
|
150283
|
150284
|
150287
|
150305
|
150308
|
150309
|
153110
|
153111
|
153112
|
153113
|
154094
|
156410
|
156470
|
156471
|
156472
|
156473
|
156474
|
156475
|
156476
|
156477
|
156478
|
156479
|
156481
|
156482
|
156483
|
156504
|
156505
|
159327
|
159328
|
159329
|
159330
|
159340
|
159343
|
159386
|
159389
|
159395
|
159397
|
159398
|
159399
|
159400
|
159401
|
159402
|
159403
|
159404
|
159405
|
159406
|
159407
|
161724