From 2a9c8095ee392fc8a461e59983ceb0c4f49f6201 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 13 Dec 2023 10:32:12 +0100 Subject: [PATCH] Bug 35557: Remove LoadResultsCovers The JS function LoadResultsCovers is not used from the Staff interface. It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag. Test plan: Confirm that LoadResultsCovers was called but had no effect. Note that the selector ^local-thumbnail only exists in shelfbrowser.inc but results.js is only used from results.tt (not shelfbrowser.inc) --- .../intranet-tmpl/prog/js/localcovers.js | 38 ------------------- .../intranet-tmpl/prog/js/pages/results.js | 4 -- 2 files changed, 42 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/localcovers.js b/koha-tmpl/intranet-tmpl/prog/js/localcovers.js index fe94760aa4f..aa9c3b16267 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/localcovers.js +++ b/koha-tmpl/intranet-tmpl/prog/js/localcovers.js @@ -38,42 +38,4 @@ KOHA.LocalCover = { mydiv.append(img); } }, - LoadResultsCovers: function(){ - $("div [id^=local-thumbnail]").each(function(i) { - var mydiv = this; - var message = document.createElement("span"); - $(message).attr("class","no-image thumbnail"); - $(message).html( __("No cover image available") ); - $(mydiv).append(message); - var img = $(""); - img.attr('src','/cgi-bin/koha/catalogue/image.pl?thumbnail=1&biblionumber=' + $(mydiv).attr("class")) - .addClass("thumbnail") - .load(function () { - if (!this.complete || typeof this.naturalWidth == "undefined" || this.naturalWidth <= 1) { - //IE HACK - try { - var otherCovers = $(mydiv).closest('td').find('img'); - var nbCovers = otherCovers.length; - if(nbCovers > 0){ - var badCovers = 0; - otherCovers.each(function(){ - if(this.naturalWidth <= 1){ - $(this).parent().remove(); - badCovers++; - } - }); - if(badCovers < nbCovers){ - $(mydiv).parent().remove(); - } - } - } - catch(err){ - } - } else { - $(mydiv).append(img); - $(mydiv).children('.no-image').remove(); - } - }); - }); - } }; diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js index 511dc7d1c19..72dc9304f01 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js @@ -231,10 +231,6 @@ $(document).ready(function() { } } - if( PREF_LocalCoverImages ){ - KOHA.LocalCover.LoadResultsCovers(); - } - if( PREF_IntranetCoce && PREF_CoceProviders ){ KOHA.coce.getURL( CoceHost, CoceProviders ); } -- 2.34.1