Bugzilla – Attachment 159885 Details for
Bug 35547
When using "Add to a list" button with more than 10 lists, "staff only" does not show up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
Bug-35547-When-using-Add-to-a-list-dialog--addbybi.patch (text/plain), 1.73 KB, created by
ByWater Sandboxes
on 2023-12-15 12:06:47 UTC
(
hide
)
Description:
Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2023-12-15 12:06:47 UTC
Size:
1.73 KB
patch
obsolete
>From f09d2e7dc11fcaeb24d772a779c09f138967c8d2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 12 Dec 2023 10:27:07 -0500 >Subject: [PATCH] Bug 35547: When using "Add to a list" dialog ( > addbybiblionumber.pl ) list that are "staff only" do not show up > >When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. > >Test plan: >1) Create 11 "staff only" lists as staff member A >2) Log in as staff member B >3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here >4) In the pulldown, choose the "More lists" option >5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" >6) Apply this patch >7) Restart all the things! >8) Click the "More lists" option again >9) Those lists should now be in the pulldown! > >Signed-off-by: sabrina <kiehl@mpis.mpg.de> >Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi> >--- > virtualshelves/addbybiblionumber.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl >index ff0ef5045b..59a33c2387 100755 >--- a/virtualshelves/addbybiblionumber.pl >+++ b/virtualshelves/addbybiblionumber.pl >@@ -170,6 +170,7 @@ if ($newvirtualshelf) { > owner => $loggedinuser, > }, > allow_change_from_others => 1, >+ allow_change_from_staff => 1, > ], > }, > { order_by => 'shelfname' } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35547
:
159743
|
159836
|
159885
|
160224