From 0b7b62f4b2f07d8e8add1baea14508b472bab43f Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 10 Dec 2023 14:55:20 +0000 Subject: [PATCH] Bug 35528: Remove 'click' from links in system preferences It's not necessary to label a link with 'click', it being a link and being formatted as such is enough. This updates the occurences in the sytem preferences editor. To test: * Go to system preferences like OpacUserCSS that allow editing in a textarea * Verify link descrptions for editing and collapsing the area * For a section of grouped system preferences, hover over the arrow and verify the text for collapsing/uncollapsing the area * Apply patch, restart all * Verify the links and tool tips have been updated Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/admin/preferences.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt index 56de788a6a4..deaaadb9826 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ -103,7 +103,7 @@ [Overridden] [% END %] - + [% UNLESS ( loop.last ) %]
[% END %] [% END %] @@ -154,9 +154,9 @@ [% IF ( CHUNK.syntax == "text/html" && Koha.Preference('UseWYSIWYGinSystemPreferences') ) %] [% ELSE %] - Click to edit + Edit - + [% END %] [% ELSIF ( CHUNK.type_languages ) %]
    diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js index 53a0db82eab..d13ec127c33 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js @@ -211,17 +211,17 @@ $( document ).ready( function () { addCollapseHandler(); - $("h3").attr("class", "expanded").attr("title", __("Click to collapse this section")); + $("h3").attr("class", "expanded").attr("title", __("Collapse this section")); var collapsible = $(".collapsed,.expanded"); $(collapsible).on("click",function(){ var h3Id = $(this).attr("id"); var panel = $("#collapse_" + h3Id); if(panel.is(":visible")){ - $(this).addClass("collapsed").removeClass("expanded").attr("title", __("Click to expand this section") ); + $(this).addClass("collapsed").removeClass("expanded").attr("title", __("Expand this section") ); panel.hide(); } else { - $(this).addClass("expanded").removeClass("collapsed").attr("title", __("Click to collapse this section") ); + $(this).addClass("expanded").removeClass("collapsed").attr("title", __("Collapse this section") ); panel.show(); } }); @@ -233,7 +233,7 @@ $( document ).ready( function () { href = href.replace("#",""); var panel = $("#collapse_" + href ); if( panel.is(":hidden") ){ - $("#" + href).addClass("expanded").removeClass("collapsed").attr("title", __("Click to collapse this section") ); + $("#" + href).addClass("expanded").removeClass("collapsed").attr("title", __("Collapse this section") ); panel.show(); } }); @@ -406,8 +406,8 @@ $( document ).ready( function () { '
    ' + ' ' + ' ' + '
    ' + ' ' + __('Delete') + '' + -- 2.43.0