From 28a98f23725ecb9662099073132b8915e82f343f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 24 Jan 2024 16:24:51 +0100 Subject: [PATCH] Bug 35890: Remove var loggedin It is never used and add confusion --- C4/Auth.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index c449c318a92..207f9328bbf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -814,7 +814,6 @@ sub checkauth { _version_check( $type, $query ); # state variables - my $loggedin = 0; my $auth_state = 'failed'; my %info; my ( $userid, $cookie, $sessionID, $flags ); @@ -854,7 +853,6 @@ sub checkauth { -secure => ( C4::Context->https_enabled() ? 1 : 0 ), -sameSite => 'Lax', )); - $loggedin = 1; } elsif ( $emailaddress) { # the Google OpenID Connect passes an email address @@ -1200,7 +1198,6 @@ sub checkauth { my $domain = $branches->{$branchcode}->{'branchip'}; $domain =~ s|\.\*||g; if ( $ip !~ /^$domain/ ) { - $loggedin = 0; $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( -name => 'CGISESSID', -value => '', -- 2.34.1