Bugzilla – Attachment 16153 Details for
Bug 9239
Koha should share Evergreen's QueryParser module for parsing queries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9239 QA follow-up: escape quotes in searches
PASSED-QA-Bug-9239-QA-follow-up-escape-quotes-in-s.patch (text/plain), 1.55 KB, created by
Katrin Fischer
on 2013-03-14 21:39:08 UTC
(
hide
)
Description:
[PASSED QA] Bug 9239 QA follow-up: escape quotes in searches
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-03-14 21:39:08 UTC
Size:
1.55 KB
patch
obsolete
>From 685c7c2ea34ce44a8a784925be65c12459451e51 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Thu, 14 Mar 2013 10:50:41 -0400 >Subject: [PATCH] [PASSED QA] Bug 9239 QA follow-up: escape quotes in searches > >This patch escapes quotes in searches for those rare instances where >there is a literal quote inside a search term. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > Koha/QueryParser/Driver/PQF/query_plan/node.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/QueryParser/Driver/PQF/query_plan/node.pm b/Koha/QueryParser/Driver/PQF/query_plan/node.pm >index 3727e34..2695058 100644 >--- a/Koha/QueryParser/Driver/PQF/query_plan/node.pm >+++ b/Koha/QueryParser/Driver/PQF/query_plan/node.pm >@@ -54,6 +54,7 @@ sub target_syntax { > if (@{$self->phrases}) { > foreach my $phrase (@{$self->phrases}) { > if ($phrase) { >+ $phrase =~ s/"/\\"/g; > $pqf .= ' @or ' x (scalar(@fields) - 1); > foreach my $attributes (@fields) { > $pqf .= $attributes->{'attr_string'} . ($attributes->{'4'} ? '' : ' @attr 4=1') . ' "' . $phrase . '" '; >@@ -66,6 +67,7 @@ sub target_syntax { > if (ref($atom)) { > $atom_content = $atom->target_syntax($server); > if ($atom_content) { >+ $atom_content =~ s/"/\\"/g; > $pqf .= ' @or ' x (scalar(@fields) - 1); > foreach my $attributes (@fields) { > $attributes->{'attr_string'} ||= ''; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9239
:
14020
|
14021
|
14022
|
14023
|
14172
|
14173
|
14174
|
14175
|
14180
|
14181
|
14182
|
14183
|
14847
|
14949
|
14950
|
14951
|
14952
|
14953
|
15121
|
15437
|
15865
|
15867
|
15929
|
15999
|
16004
|
16051
|
16125
|
16130
|
16131
|
16132
|
16133
|
16136
|
16140
|
16141
|
16142
|
16143
|
16144
|
16145
|
16146
|
16147
|
16148
|
16149
|
16150
|
16151
|
16152
|
16153
|
16154
|
16155
|
16180
|
16181
|
16182
|
16183
|
16184
|
16185
|
16186
|
16187
|
16188
|
16189
|
16190
|
16191
|
16192
|
16193
|
16194
|
16195