Bugzilla – Attachment 161760 Details for
Bug 34234
Item groups dropdown in detail page modal does not respect display order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34234: Respect display_order in additem.tt and detail.tt
Bug-34234-Respect-displayorder-in-additemtt-and-de.patch (text/plain), 2.68 KB, created by
Victor Grousset/tuxayo
on 2024-02-05 13:00:53 UTC
(
hide
)
Description:
Bug 34234: Respect display_order in additem.tt and detail.tt
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-02-05 13:00:53 UTC
Size:
2.68 KB
patch
obsolete
>From d6993f2895c89651f3461aa14d771cc1e066accf Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 12 Jan 2024 17:35:24 +0000 >Subject: [PATCH] Bug 34234: Respect display_order in additem.tt and detail.tt > >1. APPLY PATCH >2. EnableItemGroups >3. Find a record and add some new item groups with display orders that are different from the order in which the groups were added >4. Check the checkbox next to one or more items and click the link to "Add/move to item group" >5. Ensure display order is correct >6. Now add a new item to the record and scroll down to the dropdown underneath "+ Add to item group" >7. Display order should be correct. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 9764f45735..cfea7f00a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1246,7 +1246,7 @@ > <p> > <label for="item_group" class="required">Item group: </label> > <select name="item_group" id="item-group-add-form-select"> >- [% FOREACH ig IN biblio.item_groups %] >+ [% FOREACH ig IN biblio.item_groups.search({}, {order_by => 'display_order'}) %] > <option value="[% ig.id | html %]">[% ig.description | html %]</option> > [% END %] > </select> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index f1eb5ebc8b..97b9dcb65a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -260,7 +260,7 @@ > <label for="select_item_group">Options: </label> > <select name="item_group" id="item-group-add-or-create-form-select"> > <optgroup label="Use existing item group"> >- [% FOREACH ig IN item_groups %] >+ [% FOREACH ig IN biblio.item_groups.search({}, {order_by => 'display_order'}) %] > <option value="[% ig.id | html %]">[% ig.description | html %]</option> > [% END %] > </optgroup> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34234
:
158148
|
158294
|
158328
|
158329
|
160442
|
160542
|
160543
|
160992
|
161019
| 161760