From c913241843f7f1258e112dcb2c8674ef1789d138 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Mon, 29 Apr 2024 16:01:59 -0400 Subject: [PATCH] Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct Signed-off-by: Martin Renvoize --- .../mysql/en/mandatory/sample_notices.yml | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml index 9675b3eb4f1..2f4b2da430d 100644 --- a/installer/data/mysql/en/mandatory/sample_notices.yml +++ b/installer/data/mysql/en/mandatory/sample_notices.yml @@ -1773,18 +1773,18 @@ tables: message_transport_type: email lang: default content: - - "Dear <> <>," + - "Dear [% borrower.firstname %] [% borrower.surname %]," - "" - - "You have a hold available for pickup as of <>:" + - "You have a hold available for pickup as of [% hold.waitingdate | $KohaDates %]:" - "" - - "Title: <>" - - "Author: <>" - - "Copy: <>" - - "Location: <>" - - "<>" - - "<>" - - "<>" - - "<> <>" + - "Title: [% biblio.title %]" + - "Author: [% biblio.author %]" + - "Copy: [% item.copynumber %]" + - "Location: [% branch.branchname %]" + - "[% branch.branchaddress1 %]" + - "[% branch.branchaddress2 %]" + - "[% branch.branchaddress3 %]" + - "[% branch.branchcity %] [% branch.branchzip %]" - module: reserves code: HOLDDGST @@ -1829,13 +1829,13 @@ tables: branchcode: "" name: "Hold available for pickup" is_html: 0 - title: "Hold available for pickup at <>" + title: "Hold available for pickup at [% branch.branchname %]" message_transport_type: sms lang: default content: - - "Dear <> <>," + - "Dear [% borrower.firstname %] [% borrower.surname %]," - "" - - "Your hold for <> is available for pickup." + - "Your hold for [% biblio.title %] is available for pickup." - module: reserves code: HOLD @@ -1846,9 +1846,9 @@ tables: message_transport_type: print lang: default content: - - "<>" - - "<>" - - "<>" + - "[% branch.branchname %]" + - "[% branch.branchaddress1 %]" + - "[% branch.branchaddress2 %]" - "" - "" - "Change service requested" @@ -1859,9 +1859,9 @@ tables: - "" - "" - "" - - "<> <>" - - "<>" - - "<> <>" + - "[% borrower.firstname %] [% borrower.surname %]" + - "[% borrower.address %]" + - "[% borrower.city %] [% borrower.zipcode %]" - "" - "" - "" @@ -1872,13 +1872,13 @@ tables: - "" - "" - "" - - "<> <> <>" + - "[% borrower.firstname %] [% borrower.surname %] [% borrower.cardnumber %]" - "" - - "You have a hold available for pickup as of <>:" + - "You have a hold available for pickup as of [% hold.waitingdate | $KohaDates %]:" - "" - - "Title: <>" - - "Author: <>" - - "Copy: <>" + - "Title: [% biblio.title %]" + - "Author: [% biblio.author %]" + - "Copy: [% item.copynumber %]" - "" - module: reserves -- 2.45.0