Bugzilla – Attachment 17018 Details for
Bug 9873
Quiet errors in the log from XSLT.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9873 - Quiet errors in the log from XSLT.pm
Bug-9873---Quiet-errors-in-the-log-from-XSLTpm.patch (text/plain), 1.56 KB, created by
Chris Cormack
on 2013-03-29 09:54:01 UTC
(
hide
)
Description:
Bug 9873 - Quiet errors in the log from XSLT.pm
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-03-29 09:54:01 UTC
Size:
1.56 KB
patch
obsolete
>From 42000928c233fc085423b9bc9cd9513e9576dc1a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 20 Mar 2013 11:01:30 -0400 >Subject: [PATCH] Bug 9873 - Quiet errors in the log from XSLT.pm > >If XSLTResultsDisplay is enabled and items in your search results lack a >shelving location or a ccode errors will appear in the log complaining >of "uninitialized value in hash element." This patch adds a check on >these values to quiet the errors. > >To test, find or create a record with items which have no shelving >location and/or no collection code. Perform a search the results for >which will include your record. Check for errors in the log. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > C4/XSLT.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/XSLT.pm b/C4/XSLT.pm >index 139ddd2..bab03bc 100644 >--- a/C4/XSLT.pm >+++ b/C4/XSLT.pm >@@ -279,8 +279,8 @@ sub buildKohaItemsNamespace { > $status = "available"; > } > my $homebranch = $item->{homebranch}? xml_escape($branches->{$item->{homebranch}}->{'branchname'}):''; >- $location = xml_escape($shelflocations->{$item->{location}}); >- $ccode = xml_escape($ccodes->{$item->{ccode}}); >+ $location = $item->{location}? xml_escape($shelflocations->{$item->{location}}):''; >+ $ccode = $item->{ccode}? xml_escape($ccodes->{$item->{ccode}}):''; > my $itemcallnumber = xml_escape($item->{itemcallnumber}); > $xml.= "<item><homebranch>$homebranch</homebranch>". > "<location>$location</location>". >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9873
:
16535
|
17018
|
17067