From 000a24a5258f4f4c31c8776783e10af0d9fcd7d6 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Fri, 12 Apr 2013 17:24:17 +0200 Subject: [PATCH] Bug 10033 - dangerous query in _koha_modify_item The SQL query build in C4::Items::_koha_modify_item performs an update on a row of items table identified by itemnumber. Actually the query is build using a hash of datas : for my $key ( keys %$item ) { $query.="$key=?,"; push @bind, $item->{$key}; } But this hash contains 'itemnumber' key, so you get an update including the primary key. It is actually harmless but may be dangerous. This patch simply skips itemnumber key in above loop. Test plan : Check you can create and modify items. --- C4/Items.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Items.pm b/C4/Items.pm index e173dc2..b02a6a2 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -2254,6 +2254,7 @@ sub _koha_modify_item { my $query = "UPDATE items SET "; my @bind; for my $key ( keys %$item ) { + next if $key eq 'itemnumber'; $query.="$key=?,"; push @bind, $item->{$key}; } -- 1.7.10.4