Bugzilla – Attachment 1762 Details for
Bug 4003
default value not respected for serials & acq
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
0001-4003-default-value-in-PrepareItemrecordDisplay.patch (text/plain), 4.22 KB, created by
Chris Cormack
on 2009-12-24 13:45:00 UTC
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-12-24 13:45:00 UTC
Size:
4.22 KB
patch
obsolete
>From eedce2f50d6854bdb34ed20a246dc84362498b58 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Thu, 24 Dec 2009 14:43:13 +0100 >Subject: [PATCH] #4003 default value in PrepareItemrecordDisplay >Content-Type: text/plain; charset="utf-8" > >The default value you can define in cataloguing framework was not used for item created from acq or serial recieve >--- > C4/Biblio.pm | 21 +++++++++++---------- > 1 files changed, 11 insertions(+), 10 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 7b17981..8b918db 100755 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -2294,14 +2294,15 @@ sub PrepareItemrecordDisplay { > $subfield_data{repeatable} = $tagslib->{$tag}->{$subfield}->{repeatable}; > $subfield_data{hidden} = "display:none" > if $tagslib->{$tag}->{$subfield}->{hidden}; >- my ( $x, $value ); >+ my ( $x, $defaultvalue ); > if ($itemrecord) { >- ( $x, $value ) = _find_value( $tag, $subfield, $itemrecord ); >+ ( $x, $defaultvalue ) = _find_value( $tag, $subfield, $itemrecord ); > } >- if ( !defined $value ) { >- $value = q||; >+ $defaultvalue = $tagslib->{$tag}->{$subfield}->{defaultvalue} unless $defaultvalue; >+ if ( !defined $defaultvalue ) { >+ $defaultvalue = q||; > } >- $value =~ s/"/"/g; >+ $defaultvalue =~ s/"/"/g; > > # search for itemcallnumber if applicable > if ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.itemcallnumber' >@@ -2310,7 +2311,7 @@ sub PrepareItemrecordDisplay { > my $CNsubfield = substr( C4::Context->preference('itemcallnumber'), 3, 1 ); > my $temp = $itemrecord->field($CNtag) if ($itemrecord); > if ($temp) { >- $value = $temp->subfield($CNsubfield); >+ $defaultvalue = $temp->subfield($CNsubfield); > } > } > if ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.itemcallnumber' >@@ -2318,7 +2319,7 @@ sub PrepareItemrecordDisplay { > && $defaultvalues->{'callnumber'} ) { > my $temp = $itemrecord->field($subfield) if ($itemrecord); > unless ($temp) { >- $value = $defaultvalues->{'callnumber'} if $defaultvalues; >+ $defaultvalue = $defaultvalues->{'callnumber'} if $defaultvalues; > } > } > if ( ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.holdingbranch' || $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.homebranch' ) >@@ -2326,7 +2327,7 @@ sub PrepareItemrecordDisplay { > && $defaultvalues->{'branchcode'} ) { > my $temp = $itemrecord->field($subfield) if ($itemrecord); > unless ($temp) { >- $value = $defaultvalues->{branchcode} if $defaultvalues; >+ $defaultvalue = $defaultvalues->{branchcode} if $defaultvalues; > } > } > if ( $tagslib->{$tag}->{$subfield}->{authorised_value} ) { >@@ -2381,14 +2382,14 @@ sub PrepareItemrecordDisplay { > $subfield_data{marc_value} = CGI::scrolling_list( > -name => 'field_value', > -values => \@authorised_values, >- -default => "$value", >+ -default => "$defaultvalue", > -labels => \%authorised_lib, > -size => 1, > -tabindex => '', > -multiple => 0, > ); > } else { >- $subfield_data{marc_value} = "<input type=\"text\" name=\"field_value\" value=\"$value\" size=\"50\" maxlength=\"255\" />"; >+ $subfield_data{marc_value} = "<input type=\"text\" name=\"field_value\" value=\"$defaultvalue\" size=\"50\" maxlength=\"255\" />"; > } > push( @loop_data, \%subfield_data ); > } >-- >1.6.3.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4003
: 1762