Bugzilla – Attachment 18137 Details for
Bug 10243
Holds queue is making transfer requests that contradict the branch holds policy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy
Bug-10243---Holds-queue-is-making-transfer-request.patch (text/plain), 2.45 KB, created by
Kyle M Hall
on 2013-05-14 20:02:40 UTC
(
hide
)
Description:
Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2013-05-14 20:02:40 UTC
Size:
2.45 KB
patch
obsolete
>From ce9a1b9d740f29e1159f5f7510f31b3ceef52be7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 14 May 2013 14:59:07 -0500 >Subject: [PATCH] Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy > >For some reason MapItemsToHoldRequests will, as a last ditch effort, >grab what seems to be an arbitrary available item to fill a hold request, >even if it will violate the circulation rules for holds. > >In other words, even if an item matches a "Holds policy by item type" >that says "From home library", a request to transfer that item to >another library will be added to the holds queue! > >Test Plan: >1) Create a record with a an item at BranchA of item type BOOK >2) Set the holds policy such that itemtype BOOK for BranchA is set > to "From home library" >3) Place a bib-level hold request for a patron with a pickup at BranchB >4) Run build_holds_queue.pl >5) You should now see a request for that item to be transfered to > BranchB, even though the rules should not allow this. >6) Apply this patch >7) Run build_holds_queue.pl again >8) View the holds queue again, that request should no longer exist >--- > C4/HoldsQueue.pm | 13 ++++++++++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 655269b..ab41f74 100755 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -334,7 +334,7 @@ sub GetItemsAvailableToFillHoldRequestsForBib { > my @items = grep { ! scalar GetTransfers($_->{itemnumber}) } @$itm; > return [ grep { > my $rule = GetBranchItemRule($_->{homebranch}, $_->{itype}); >- $_->{holdallowed} = $rule->{holdallowed} != 0 >+ $_->{holdallowed} = $rule->{holdallowed}; > } @items ]; > } > >@@ -467,8 +467,15 @@ sub MapItemsToHoldRequests { > last PULL_BRANCHES; > } > } >- $itemnumber ||= $items_by_branch{$holdingbranch}->[0]->{itemnumber} >- if $holdingbranch; >+ >+ unless ( $itemnumber ) { >+ foreach my $current_item ( @{ $items_by_branch{$holdingbranch} } ) { >+ if ( $holdingbranch && ( $current_item->{holdallowed} == 2 || $pickup_branch eq $current_item->{homebranch} ) ) { >+ $itemnumber = $current_item->{itemnumber}; >+ last; # quit this loop as soon as we have a suitable item >+ } >+ } >+ } > } > > if ($itemnumber) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10243
:
18137
|
18138
|
18160
|
19097
|
21121
|
21927