From cad5db1f882a7a2983647e30c97eaef55ce18447 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 14 May 2013 16:07:50 -0400 Subject: [PATCH] Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy - Alternate solution For some reason MapItemsToHoldRequests will, as a last ditch effort, grab what seems to be an arbitrary available item to fill a hold request, even if it will violate the circulation rules for holds. In other words, even if an item matches a "Holds policy by item type" that says "From home library", a request to transfer that item to another library will be added to the holds queue! Test Plan: 1) Create a record with a an item at BranchA of item type BOOK 2) Set the holds policy such that itemtype BOOK for BranchA is set to "From home library" 3) Place a bib-level hold request for a patron with a pickup at BranchB 4) Run build_holds_queue.pl 5) You should now see a request for that item to be transfered to BranchB, even though the rules should not allow this. 6) Apply this patch 7) Run build_holds_queue.pl again 8) View the holds queue again, that request should no longer exist --- C4/HoldsQueue.pm | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index dc43113..19f339d 100755 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -470,8 +470,6 @@ sub MapItemsToHoldRequests { last PULL_BRANCHES; } } - $itemnumber ||= $items_by_branch{$holdingbranch}->[0]->{itemnumber} - if $holdingbranch; } if ($itemnumber) { -- 1.7.2.5