Bugzilla – Attachment 18168 Details for
Bug 9824
Hide basket with no expected items in basket list by bookseller
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by bookseller
SIGNED-OFF-Bug-9824---Hide-basket-with-no-expected.patch (text/plain), 1.38 KB, created by
Owen Leonard
on 2013-05-16 13:05:54 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by bookseller
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-05-16 13:05:54 UTC
Size:
1.38 KB
patch
obsolete
>From 24f9a02b9a249e106994a8249be9004f1ccd773e Mon Sep 17 00:00:00 2001 >From: Lyon3 Team <koha@univ-lyon3.fr> >Date: Thu, 21 Mar 2013 14:47:43 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 9824 - Hide basket with no expected items > in basqket list by bookseller >Content-Type: text/plain; charset="utf-8" > >Before patch you will see in acqui/booksellers.pl all the baskets ever >created. >After the patch you will see in acqui/booksellers.pl only the basket >with expected items. > >Test plan : >* Create a basket with some orders lines >You should see this basket in acqui/booksellers.pl >* receive or cancel all the line in this basket >This basket shouldn't appear any more in acqui/booksellers.pl > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > C4/Acquisition.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index d11f2a9..2bbb21c 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -595,7 +595,8 @@ sub GetBasketsInfosByBookseller { > ) AS expected_items > FROM aqbasket > LEFT JOIN aqorders ON aqorders.basketno = aqbasket.basketno >- WHERE booksellerid = ? >+ WHERE booksellerid = ? AND ( aqorders.quantity > aqorders.quantityreceived OR quantityreceived IS NULL) >+ AND datecancellationprinted IS NULL > GROUP BY aqbasket.basketno > }; > my $sth = $dbh->prepare($query); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9824
:
16168
|
16639
|
18168
|
18184
|
18214
|
18215
|
18219
|
18220
|
18221
|
18311
|
18312
|
18313
|
18332
|
18336
|
18348
|
18506