Bugzilla – Attachment 18256 Details for
Bug 10163
batch-mod items tool fails on files over 1000 lines long
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-10163-Allow-batch-mod-on-item-lists-1000-lines.patch (text/plain), 1.74 KB, created by
Colin Campbell
on 2013-05-20 15:15:34 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2013-05-20 15:15:34 UTC
Size:
1.74 KB
patch
obsolete
>From e1eeca372ff7bda00d9321f4d39896f50901e1c5 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 20 May 2013 16:02:28 +0100 >Subject: [PATCH] Bug 10163: Allow batch-mod on item lists > 1000 lines > >An earlier bugfix to deal with lists of 0 items >inadvertantly renoved the ability to process >lists creater than 1000 items >The error is that the flag too_many_items and the list item_loop >are mutually exclusive either one or the other exists >but not both. >Change logic so it accounts for this >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 85a8db9..937b59e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -82,10 +82,8 @@ $(document).ready(function(){ > [% END %] > </tbody> > </table> >- [% IF ( item_loop ) %] >- [% UNLESS ( too_many_items ) %] >+ [% IF item_loop %] > <h4>The following barcodes were found: </h4> >- [% END %] > [% END %] > [% END %] <!-- /notfoundbarcodes --> > >@@ -96,7 +94,7 @@ $(document).ready(function(){ > <input type="hidden" name="completedJobID" id="completedJobID" value="" /> > <input type="hidden" name="src" id="src" value="[% src %]" /> > >-[% IF ( item_loop ) %] >+[% IF item_loop || too_many_items %] > [% IF ( show ) %]<div id="toolbar"><a id="selectallbutton" href="#">Select All</a> | <a id="clearallbutton" href="#">Clear All</a></div>[% ELSE %][% END %] > <div id="cataloguing_additem_itemlist"> > >-- >1.8.3.rc2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10163
:
17859
|
18256
|
20056
|
45326
|
45723