Bugzilla – Attachment 18828 Details for
Bug 10297
categorycode and branchcode should be required when adding patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 10297 - categorycode and branchcode should be required when adding patrons
SIGNED-OFF-Bug-10297---categorycode-and-branchcode.patch (text/plain), 2.46 KB, created by
David Cook
on 2013-06-11 03:18:45 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 10297 - categorycode and branchcode should be required when adding patrons
Filename:
MIME Type:
Creator:
David Cook
Created:
2013-06-11 03:18:45 UTC
Size:
2.46 KB
patch
obsolete
>From 425fcb700f161244e26fa764a604f53a2c6a1be6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 10 Jun 2013 11:14:41 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 10297 - categorycode and branchcode should > be required when adding patrons > >categorycode and branchcode should show as required under all >circumstances, not just when they are included in the >BorrowerMandatoryField system preference. This patch adds the correct >classes and hints to those fields. > >To test, view the patron entry form for a new or existing patron. >Category and Library should show that they are required. > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > .../prog/en/modules/members/memberentrygen.tt | 14 ++++---------- > 1 files changed, 4 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 6b293f1..1bb8e3e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -989,13 +989,8 @@ > [% END %] > [% UNLESS nobranchcode %] > <li> >- [%- IF ( mandatorybranchcode ) -%] >- <label for="branchcode" class="required"> >- [%- ELSE -%] >- <label for="branchcode"> >- [%- END -%] >- Library:</label> >- <select name="branchcode" size="1" id="branchcode"> >+ <label for="branchcode" class="required">Library:</label> >+ <select name="branchcode" size="1" id="branchcode"> > [%- FOREACH branchloo IN branchloop %] > [% IF ( branchloo.selected ) -%] > <option value="[% branchloo.branchcode %]" selected="selected">[% branchloo.branchname %]</option> >@@ -1004,13 +999,11 @@ > [%- END -%] > [%- END %] > </select> >- [% IF ( mandatorybranchcode ) -%] > <span class="required">Required</span> >- [%- END %] > </li> > [% END %] > <li> >- <label for="categorycode">Category: </label> >+ <label for="categorycode" class="required">Category: </label> > <select id="categorycode" name="categorycode" onchange="update_category_code(this);"> > [% FOREACH typeloo IN typeloop %] > [% FOREACH categoryloo IN typeloo.categoryloop %] >@@ -1033,6 +1026,7 @@ > [% END %] > [% END %] > </select> >+ <span class="required">Required</span> > </li> > [% UNLESS nosort1 %] > <li> >-- >1.7.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10297
:
18825
| 18828