From 0fd5f635fb17254bd43ab347edb8e0f5241c23af Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 20 May 2013 09:53:38 +0200 Subject: [PATCH] [PASSED QA] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. --- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 10 +++++++--- opac/opac-detail.pl | 5 ++++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index 4e4d140..34a0a9a 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -1018,8 +1018,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
[% IF ( itemloop.size ) %] - [% IF ( lotsofitems ) %] -

This record has many physical items. Click here to view them all.

+ [% IF ( lotsofholdingsitems ) %] +

This record has many physical items. Click here to view them all.

[% ELSE %] [% INCLUDE items_table items=itemloop tab="holdings" %] [% END %] @@ -1054,7 +1054,11 @@ YAHOO.util.Event.onContentReady("furtherm", function () { [% IF (SeparateHoldings) %]
[% IF (otheritemloop.size) %] - [% INCLUDE items_table items=otheritemloop tab="otherholdings" %] + [% IF lotsofothersholdingsitems %] +

This record has many physical items. Click here to view them all.

+ [% ELSE %] + [% INCLUDE items_table items=otheritemloop tab="otherholdings" %] + [% END %] [% ELSE %] No other items. [% END %] diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 9d0851f..b4ad6a5 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -624,7 +624,10 @@ if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) { # TODO: The limit of 50 could be a syspref my $viewallitems = $query->param('viewallitems'); if (scalar(@itemloop) >= 50 && !$viewallitems) { - $template->param('lotsofitems' => 1); + $template->param('lotsofholdingsitems' => 1); +} +if (scalar(@otheritemloop) >= 50 && !$viewallitems) { + $template->param('lotsofothersholdingsitems' => 1); } ## get notes and subjects from MARC record -- 1.7.9.5