From 853b360a589693d3d882d5db85d222fa4ad55e4d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 25 Jun 2013 09:09:38 +0200 Subject: [PATCH] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. --- C4/Acquisition.pm | 33 +-------------------------------- cataloguing/moveitem.pl | 2 +- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index b6fab5d..e294183 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -59,7 +59,7 @@ BEGIN { &ModReceiveOrder &CancelReceipt &ModOrderBiblioitemNumber &GetCancelledOrders &GetLastOrderNotReceivedFromSubscriptionid &GetLastOrderReceivedFromSubscriptionid - &NewOrderItem &ModOrderItem &ModItemOrder + &NewOrderItem &ModItemOrder &GetParcels &GetParcel &GetContracts &GetContract @@ -1257,37 +1257,6 @@ sub ModOrder { #------------------------------------------------------------# -=head3 ModOrderItem - - &ModOrderItem(\%hashref); - -Modifies the itemnumber in the aqorders_items table. The input hash needs three entities: - -=over - -=item - itemnumber: the old itemnumber -=item - ordernumber: the order this item is attached to -=item - newitemnumber: the new itemnumber we want to attach the line to - -=back - -=cut - -sub ModOrderItem { - my $orderiteminfo = shift; - if (! $orderiteminfo->{'ordernumber'} || ! $orderiteminfo->{'itemnumber'} || ! $orderiteminfo->{'newitemnumber'}){ - die "Ordernumber, itemnumber and newitemnumber is required"; - } - - my $dbh = C4::Context->dbh; - - my $query = "UPDATE aqorders_items set itemnumber=? where itemnumber=? and ordernumber=?"; - my @params = ($orderiteminfo->{'newitemnumber'}, $orderiteminfo->{'itemnumber'}, $orderiteminfo->{'ordernumber'}); - my $sth = $dbh->prepare($query); - $sth->execute(@params); - return 0; -} - =head3 ModItemOrder ModItemOrder($itemnumber, $ordernumber); diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl index 24414cc..2622c36 100755 --- a/cataloguing/moveitem.pl +++ b/cataloguing/moveitem.pl @@ -30,7 +30,7 @@ use C4::Context; use C4::Koha; use C4::Branch; use C4::ClassSource; -use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder ModOrderItem/; +use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/; use Date::Calc qw(Today); -- 1.7.10.4