From dfa2e08cfecf23f2919ed5b30345fc720219f1b1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 17 Jul 2013 15:02:43 +0200 Subject: [PATCH] Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. --- admin/auth_tag_structure.pl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/admin/auth_tag_structure.pl b/admin/auth_tag_structure.pl index 906f8d3..977039c 100755 --- a/admin/auth_tag_structure.pl +++ b/admin/auth_tag_structure.pl @@ -57,7 +57,7 @@ my ($template, $loggedinuser, $cookie) # get authtype list my $authtypes = getauthtypes; my @authtypesloop = (); -foreach my $thisauthtype ( keys %{$authtypes} ) { +foreach my $thisauthtype ( sort keys %{$authtypes} ) { push @authtypesloop, { value => $thisauthtype, selected => $thisauthtype eq $authtypecode, @@ -209,6 +209,7 @@ if ($op eq 'add_form') { push @existingauthtypeloop,\%line; } } + @existingauthtypeloop = sort @existingauthtypeloop; $template->param(existingauthtypeloop => \@existingauthtypeloop, authtypecode => $authtypecode, ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt index fc61789..a2a796a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt @@ -192,7 +192,6 @@ return false; Create authority framework for [% authtypecode %] using - [% FOREACH authtypeloo IN authtypeloop %] [% IF ( authtypeloo.selected ) %] -- 1.7.10.4