From 7feb8c2b5cc2ca50c21991e03fd5389bbf7054e8 Mon Sep 17 00:00:00 2001 From: Kenza Zaki Date: Mon, 12 Aug 2013 14:40:50 +0200 Subject: [PATCH] Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS --- C4/Circulation.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 310cefa..bd08536 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3303,11 +3303,12 @@ sub GetOfflineOperations { } sub GetOfflineOperation { + my $operationid = shift; + return unless $operationid; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare("SELECT * FROM pending_offline_operations WHERE operationid=?"); - $sth->execute( shift ); - my $result = $sth->fetchrow_hashref; - return $result; + $sth->execute( $operationid ); + return $sth->fetchrow_hashref; } sub AddOfflineOperation { -- 1.7.9.5