Bugzilla – Attachment 20528 Details for
Bug 3134
Ability to select multiple reports to delete at once
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3134: Reindent delete_report
Bug-3134-Reindent-deletereport.patch (text/plain), 1.18 KB, created by
Jonathan Druart
on 2013-08-21 08:47:22 UTC
(
hide
)
Description:
Bug 3134: Reindent delete_report
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-08-21 08:47:22 UTC
Size:
1.18 KB
patch
obsolete
>From ce6ef24029805d391078267401ebb5182d9da5b3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 21 Aug 2013 10:35:02 +0200 >Subject: [PATCH] Bug 3134: Reindent delete_report > >The first patch add a bad indentation for this routine. This patch fixes >that. >The $sth->finish statement is useless and should be removed. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Reports/Guided.pm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 9447c71..befc777 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -610,11 +610,10 @@ sub format_results { > > sub delete_report { > my (@ids) = @_; >- my $dbh = C4::Context->dbh; >- my $query = 'DELETE FROM saved_sql WHERE id IN (' . join( ',', ('?') x @ids ) . ')'; >- my $sth = $dbh->prepare($query); >- $sth->execute(@ids); >- $sth->finish; >+ my $dbh = C4::Context->dbh; >+ my $query = 'DELETE FROM saved_sql WHERE id IN (' . join( ',', ('?') x @ids ) . ')'; >+ my $sth = $dbh->prepare($query); >+ $sth->execute(@ids); > } > > my $SAVED_REPORTS_BASE_QRY = <<EOQ; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3134
:
14604
|
19376
|
19806
|
19843
|
20461
|
20465
|
20516
|
20517
|
20524
|
20525
|
20526
|
20527
| 20528