@@ -, +, @@ in C4::Bookseller.pm --- C4/Bookseller.pm | 4 ++-- t/db_dependent/Bookseller.t | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) --- a/C4/Bookseller.pm +++ a/C4/Bookseller.pm @@ -226,6 +226,7 @@ C<&ModBookseller> with the result. sub ModBookseller { my ($data) = @_; my $dbh = C4::Context->dbh; + return unless $data->{'id'}; my $query = 'UPDATE aqbooksellers SET name=?,address1=?,address2=?,address3=?,address4=?, postal=?,phone=?,accountnumber=?,fax=?,url=?,contact=?,contpos=?, @@ -235,7 +236,7 @@ sub ModBookseller { discount=?,notes=?,gstrate=?,deliverytime=? WHERE id=?'; my $sth = $dbh->prepare($query); - $sth->execute( + return $sth->execute( $data->{'name'}, $data->{'address1'}, $data->{'address2'}, $data->{'address3'}, $data->{'address4'}, $data->{'postal'}, @@ -253,7 +254,6 @@ sub ModBookseller { $data->{deliverytime}, $data->{'id'} ); - return; } =head2 DelBookseller --- a/t/db_dependent/Bookseller.t +++ a/t/db_dependent/Bookseller.t @@ -2,7 +2,7 @@ use Modern::Perl; -use Test::More tests => 53; +use Test::More tests => 54; use C4::Context; use Koha::DateUtils; use DateTime::Duration; @@ -248,13 +248,11 @@ $sample_supplier2 = { deliverytime => 2, }; -#FIXME : ModBookseller always returns undef, even if the id isn't given -#or doesn't exist my $modif1 = C4::Bookseller::ModBookseller(); is( $modif1, undef, "ModBookseller returns undef if no params given - Nothing happened" ); $modif1 = C4::Bookseller::ModBookseller($sample_supplier2); -#is( $modif1, 1, "ModBookseller modifies only the supplier2" ); +is( $modif1, 1, "ModBookseller modifies only the supplier2" ); is( scalar( C4::Bookseller::GetBookSeller('') ), $count + 2, "Supplier2 has been modified - Nothing added" ); --