@@ -, +, @@ value --- C4/Circulation.pm | 3 ++- t/db_dependent/Circulation_transfers.t | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) --- a/C4/Circulation.pm +++ a/C4/Circulation.pm @@ -2826,13 +2826,14 @@ sub GetTransfersFromTo { sub DeleteTransfer { my ($itemnumber) = @_; + return unless $itemnumber; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare( "DELETE FROM branchtransfers WHERE itemnumber=? AND datearrived IS NULL " ); - $sth->execute($itemnumber); + return $sth->execute($itemnumber); } =head2 AnonymiseIssueHistory --- a/t/db_dependent/Circulation_transfers.t +++ a/t/db_dependent/Circulation_transfers.t @@ -9,7 +9,7 @@ use C4::Circulation; use Koha::DateUtils; use DateTime::Duration; -use Test::More tests => 12; +use Test::More tests => 14; BEGIN { use_ok('C4::Circulation'); @@ -191,8 +191,8 @@ is( is( C4::Circulation::DeleteTransfer($item_id1), 1, "A the item1's transfer has been deleted" ); #FIXME :The following tests should pass but don't because currently the routine DeleteTransfer returns nothing -#is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef"); -#is(C4::Circulation::DeleteTransfer(-1),0,"with a wrong itemid DeleteTranfer returns 0"); +is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef"); +is(C4::Circulation::DeleteTransfer(-1),'0E0',"with a wrong itemid DeleteTranfer returns 0E0"); #End transaction $dbh->rollback; --