@@ -, +, @@ C4::Circulation.pm --- C4/Circulation.pm | 19 ------------------- 1 file changed, 19 deletions(-) --- a/C4/Circulation.pm +++ a/C4/Circulation.pm @@ -858,7 +858,6 @@ sub CanBookBeIssued { my $sth = $dbh->prepare("SELECT notforloan FROM itemtypes WHERE itemtype = ?"); $sth->execute($item->{'itemtype'}); my $notforloan=$sth->fetchrow_hashref(); - $sth->finish(); if ($notforloan->{'notforloan'}) { if (!C4::Context->preference("AllowNotForLoanOverride")) { $issuingimpossible{NOT_FOR_LOAN} = 1; @@ -2204,7 +2203,6 @@ sub _FixAccountForLostAndReturned { (?,?,?,?)"); $usth->execute($data->{'borrowernumber'},$accdata->{'accountno'},$nextaccntno,$newamtos); } - $msth->finish; # $msth might actually have data left } $amountleft *= -1 if ($amountleft > 0); my $desc = "Item Returned " . $item_id; @@ -2436,7 +2434,6 @@ END_SQL my $sth = $dbh->prepare( $statement ); $sth->execute( @bind_parameters ); my $upcoming_dues = $sth->fetchall_arrayref({}); - $sth->finish; return $upcoming_dues; } @@ -2538,7 +2535,6 @@ sub AddRenewal { ); $sth->execute( $borrowernumber, $itemnumber ); my $issuedata = $sth->fetchrow_hashref; - $sth->finish; if(defined $datedue && ref $datedue ne 'DateTime' ) { carp 'Invalid date passed to AddRenewal.'; return; @@ -2566,7 +2562,6 @@ sub AddRenewal { ); $sth->execute( $datedue->strftime('%Y-%m-%d %H:%M'), $renews, $lastreneweddate, $borrowernumber, $itemnumber ); - $sth->finish; # Update the renewal count on the item, and tell zebra to reindex $renews = $biblio->{'renewals'} + 1; @@ -2638,7 +2633,6 @@ sub GetRenewCount { $sth->execute( $bornum, $itemno ); my $data = $sth->fetchrow_hashref; $renewcount = $data->{'renewals'} if $data->{'renewals'}; - $sth->finish; # $item and $borrower should be calculated my $branchcode = _GetCircControlBranch($item, $borrower); @@ -2707,7 +2701,6 @@ sub GetIssuingCharges { } } - $sth->finish; # we havent _explicitly_ fetched all rows return ( $charge, $item_type ); } @@ -2769,7 +2762,6 @@ sub AddIssuingCharge { "; my $sth = $dbh->prepare($query); $sth->execute( $borrowernumber, $itemnumber, $nextaccntno, $charge, $charge, $manager_id ); - $sth->finish; } =head2 GetTransfers @@ -2794,7 +2786,6 @@ sub GetTransfers { my $sth = $dbh->prepare($query); $sth->execute($itemnumber); my @row = $sth->fetchrow_array(); - $sth->finish; return @row; } @@ -2824,7 +2815,6 @@ sub GetTransfersFromTo { while ( my $data = $sth->fetchrow_hashref ) { push @gettransfers, $data; } - $sth->finish; return (@gettransfers); } @@ -2843,7 +2833,6 @@ sub DeleteTransfer { AND datearrived IS NULL " ); $sth->execute($itemnumber); - $sth->finish; } =head2 AnonymiseIssueHistory @@ -2988,7 +2977,6 @@ sub updateWrongTransfer { "update branchtransfers set datearrived = now(),tobranch=?,comments='wrongtransfer' where itemnumber= ? AND datearrived IS NULL" ); $sth->execute($FromLibrary,$itemNumber); - $sth->finish; # second step create a new line of branchtransfer to the right location . ModItemTransfer($itemNumber, $FromLibrary, $waitingAtLibrary); @@ -3132,7 +3120,6 @@ my $query = qq|SELECT count(*) my $sth = $dbh->prepare($query); $sth->execute($branchcode,$week_day); my $result=$sth->fetchrow; -$sth->finish; return $result; } @@ -3164,7 +3151,6 @@ my $query=qq|SELECT count(*) my $sth = $dbh->prepare($query); $sth->execute($years,$month,$day,$branchcode); my $countspecial=$sth->fetchrow ; -$sth->finish; return $countspecial; } @@ -3193,7 +3179,6 @@ my $query=qq|SELECT count(*) my $sth = $dbh->prepare($query); $sth->execute($month,$day,$branchcode); my $countspecial=$sth->fetchrow ; -$sth->finish; return $countspecial; } @@ -3209,7 +3194,6 @@ my $query=qq|SELECT count(*) my $sth = $dbh->prepare($query); $sth->execute($barcode); my $exist=$sth->fetchrow ; -$sth->finish; return $exist; } @@ -3300,7 +3284,6 @@ sub LostItem{ WHERE issues.itemnumber=?"); $sth->execute($itemnumber); my $issues=$sth->fetchrow_hashref(); - $sth->finish; # if a borrower lost the item, add a replacement cost to the their record if ( my $borrowernumber = $issues->{borrowernumber} ){ @@ -3319,7 +3302,6 @@ sub GetOfflineOperations { my $sth = $dbh->prepare("SELECT * FROM pending_offline_operations WHERE branchcode=? ORDER BY timestamp"); $sth->execute(C4::Context->userenv->{'branch'}); my $results = $sth->fetchall_arrayref({}); - $sth->finish; return $results; } @@ -3328,7 +3310,6 @@ sub GetOfflineOperation { my $sth = $dbh->prepare("SELECT * FROM pending_offline_operations WHERE operationid=?"); $sth->execute( shift ); my $result = $sth->fetchrow_hashref; - $sth->finish; return $result; } --