Bugzilla – Attachment 21250 Details for
Bug 9374
In baskets, prices between 0 and 1 are displayed in red
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9374: Only 0.00 prices must have class error in basket.tt
Bug-9374-Only-000-prices-must-have-class-error-in-.patch (text/plain), 3.70 KB, created by
Jonathan Druart
on 2013-09-19 14:37:24 UTC
(
hide
)
Description:
Bug 9374: Only 0.00 prices must have class error in basket.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-09-19 14:37:24 UTC
Size:
3.70 KB
patch
obsolete
>From ad4012976d670f350b7e0e2a0a34aedf2407262d Mon Sep 17 00:00:00 2001 >From: Mathieu Saby <mathieu.saby@univ-rennes2.fr> >Date: Sun, 15 Sep 2013 13:09:20 +0200 >Subject: [PATCH] Bug 9374: Only 0.00 prices must have class error in > basket.tt > >A regexp '^0' in basket.tt is used to give the class "error" to null prices. >It is wrong, because it matches prices like "0.15". It should only match "0.00". > >To test : >- apply the patch >- display a basket with an order with a price between 0 and 1 (like "0.50") and an order with a price stricty null ("0.00") >- only the "0.00" price should be displayed in red > >Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 67e299d..3558616 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -367,15 +367,15 @@ > </p> > [% END %] > </td> >- <td class="number gste [% IF books_loo.rrpgste.search('^0') %]error[% END %]">[% books_loo.rrpgste %]</td> >- <td class="number gste [% IF books_loo.ecostgste.search('^0') %]error[% END %]">[% books_loo.ecostgste %]</td> >- <td class="number gsti [% IF books_loo.rrpgsti.search('^0') %]error[% END %]">[% books_loo.rrpgsti %]</td> >- <td class="number gsti [% IF books_loo.ecostgsti.search('^0') %]error[% END %]">[% books_loo.ecostgsti %]</td> >- <td class="number [% IF books_loo.quantity.search('^0') %]error[% END %]">[% books_loo.quantity %]</td> >- <td class="number gste [% IF books_loo.totalgste.search('^0') %]error[% END %]">[% books_loo.totalgste %]</td> >- <td class="number gsti [% IF books_loo.totalgsti.search('^0') %]error[% END %]">[% books_loo.totalgsti %]</td> >- <td class="number [% IF books_loo.gstgsti.search('^0') %]error[% END %]">[% books_loo.gstgsti %]</td> >- <td class="number [% IF books_loo.gstvalue.search('^0') %]error[% END %]">[% books_loo.gstvalue %]</td> >+ <td class="number gste [% IF books_loo.rrpgste.search('^0.00') %]error[% END %]">[% books_loo.rrpgste %]</td> >+ <td class="number gste [% IF books_loo.ecostgste.search('^0.00') %]error[% END %]">[% books_loo.ecostgste %]</td> >+ <td class="number gsti [% IF books_loo.rrpgsti.search('^0.00') %]error[% END %]">[% books_loo.rrpgsti %]</td> >+ <td class="number gsti [% IF books_loo.ecostgsti.search('^0.00') %]error[% END %]">[% books_loo.ecostgsti %]</td> >+ <td class="number [% IF books_loo.quantity.search('^0.00') %]error[% END %]">[% books_loo.quantity %]</td> >+ <td class="number gste [% IF books_loo.totalgste.search('^0.00') %]error[% END %]">[% books_loo.totalgste %]</td> >+ <td class="number gsti [% IF books_loo.totalgsti.search('^0.00') %]error[% END %]">[% books_loo.totalgsti %]</td> >+ <td class="number [% IF books_loo.gstgsti.search('^0.00') %]error[% END %]">[% books_loo.gstgsti %]</td> >+ <td class="number [% IF books_loo.gstvalue.search('^0.00') %]error[% END %]">[% books_loo.gstvalue %]</td> > <td>[% books_loo.budget_name %]</td> > [% IF ( active ) %] > [% UNLESS ( closedate ) %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9374
:
21107
|
21250
|
21265
|
21266
|
21268