From 2e864b749f109368f0f72ea760b53c18b549b7ea Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 19 Sep 2013 12:18:11 -0400 Subject: [PATCH] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds --- .../prog/en/modules/reserve/request.tt | 31 +++++++++++++------- 1 files changed, 20 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 20853b3..7f7d05f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -600,17 +600,26 @@ function checkMultiHold() { -- 1.7.2.5