Bugzilla – Attachment 2165 Details for
Bug 4460
Amazon's AssociateID tag not used in links so referred revenue lost
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
probably fix for this issue, hard to test fully
0001-bug-4460-Amazon-s-AssociateID-tag-not-used-in-li.patch (text/plain), 14.34 KB, created by
Reed Wade
on 2010-05-26 10:30:53 UTC
(
hide
)
Description:
probably fix for this issue, hard to test fully
Filename:
MIME Type:
Creator:
Reed Wade
Created:
2010-05-26 10:30:53 UTC
Size:
14.34 KB
patch
obsolete
>From 27e72da0af7094baf1e0799b51bdb32892069443 Mon Sep 17 00:00:00 2001 >From: Reed Wade <reed@catalyst.net.nz> >Date: Wed, 26 May 2010 22:05:40 +1200 >Subject: [PATCH] bug 4460 : - Amazon's AssociateID tag not used in links so referred revenue lost >Content-Type: text/plain; charset="utf-8" > > - Added AmazonAssocTag if set for all links from the cover art > - updated the reader url dropping some bits (/ref=sib_dp_pt/002-7879865-0184864#reader-link) that appear to have no function > - I don't have a good way to test if the associate info will actually pass through on a purchase; all AWS docs relate to the product page and not the reader page.--but I suspect this will work > > - nothing done re: 'The same might be true for other Amazon related links that koha generates' mentioned on the bug as I couldn't sort out how to trigger that >--- > C4/Auth.pm | 2 ++ > C4/External/Amazon.pm | 6 ++++++ > .../prog/en/modules/catalogue/detail.tmpl | 4 ++-- > .../opac-tmpl/prog/en/modules/opac-detail.tmpl | 2 +- > .../prog/en/modules/opac-readingrecord.tmpl | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl | 4 ++-- > 6 files changed, 14 insertions(+), 6 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 4f76ea6..a6314de 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -354,6 +354,7 @@ sub get_template_and_user { > if ( $in->{'type'} eq "intranet" ) { > $template->param( > AmazonContent => C4::Context->preference("AmazonContent"), >+ AmazonAssocTag => C4::Context->preference("AmazonAssocTag"), > AmazonCoverImages => C4::Context->preference("AmazonCoverImages"), > AmazonEnabled => C4::Context->preference("AmazonEnabled"), > AmazonSimilarItems => C4::Context->preference("AmazonSimilarItems"), >@@ -399,6 +400,7 @@ sub get_template_and_user { > } > $template->param( > AmazonContent => "" . C4::Context->preference("AmazonContent"), >+ AmazonAssocTag => C4::Context->preference("AmazonAssocTag"), > AnonSuggestions => "" . C4::Context->preference("AnonSuggestions"), > AuthorisedValueImages => C4::Context->preference("AuthorisedValueImages"), > LibraryName => "" . C4::Context->preference("LibraryName"), >diff --git a/C4/External/Amazon.pm b/C4/External/Amazon.pm >index 9e503b6..11ae79c 100644 >--- a/C4/External/Amazon.pm >+++ b/C4/External/Amazon.pm >@@ -174,6 +174,12 @@ sub SignRequest{ > return hmac_sha256_base64($string,C4::Context->preference('AWSPrivateKey')) . '='; > } > >+## >+## check_search_inside() doesn't appear to be called anywhere and is using a reader url that I think is >+## a bit out of date; it probably makes sense to drop this method unless it's going to be needed. >+## I kind of doubt it would even work given the js-ish nature of the Amazon reader page. >+## -- 26 May 2010, Reed Wade <reed@catalyst.net.nz> >+## > sub check_search_inside { > my $isbn = shift; > my $ua = LWP::UserAgent->new( >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl >index 7bd4959..3f638f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl >@@ -116,7 +116,7 @@ function verify_images() { > </div> > > <!-- TMPL_IF NAME="AmazonEnabled" --><!-- TMPL_IF NAME="AmazonCoverImages" --><div class="yui-u" id="bookcoverimg"> >-<a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="" /></a></div><!-- /TMPL_IF --><!-- /TMPL_IF --> >+<a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="" /></a></div><!-- /TMPL_IF --><!-- /TMPL_IF --> > > <div class="yui-u" style="margin-top: 1em;"> > <ul> >@@ -413,7 +413,7 @@ function verify_images() { > <!-- TMPL_IF NAME="FRBRizeEditions" --><!-- TMPL_IF NAME="XISBNS" --> > <div id="editions"><h2>Editions</h2> > <table> >-<!-- TMPL_LOOP NAME="XISBNS" --><tr><!-- TMPL_IF NAME="AmazonEnabled" --><td><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01._AA75_PU_PU-5_.jpg" /></a></td><!-- /TMPL_IF --><td><!-- TMPL_IF NAME="noItemTypeImages" --><!-- TMPL_VAR NAME="description" --><!-- TMPL_ELSE --><img src="<!-- TMPL_VAR NAME="imageurl" -->" alt="<!-- TMPL_VAR NAME="description" -->" title="<!-- TMPL_VAR NAME="description" -->"><!-- /TMPL_IF --></td><td> >+<!-- TMPL_LOOP NAME="XISBNS" --><tr><!-- TMPL_IF NAME="AmazonEnabled" --><td><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->"><img src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01._AA75_PU_PU-5_.jpg" /></a></td><!-- /TMPL_IF --><td><!-- TMPL_IF NAME="noItemTypeImages" --><!-- TMPL_VAR NAME="description" --><!-- TMPL_ELSE --><img src="<!-- TMPL_VAR NAME="imageurl" -->" alt="<!-- TMPL_VAR NAME="description" -->" title="<!-- TMPL_VAR NAME="description" -->"><!-- /TMPL_IF --></td><td> > <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" -->"><!-- TMPL_VAR NAME="title" escape="html" --></a> by <!-- TMPL_VAR NAME="author" --> ©<!-- TMPL_VAR NAME="copyrightdate" --> > <!-- TMPL_IF name="publishercode" --> > <!-- TMPL_VAR NAME="publishercode" --> <!-- TMPL_IF name="place" -->(<!-- TMPL_VAR NAME="place"-->)<!--/TMPL_IF--> <!-- TMPL_IF NAME="publicationyear" -->, <!-- TMPL_VAR NAME="publicationyear" --><!-- /TMPL_IF --> <!-- TMPL_IF NAME="editionstatement" --><!-- TMPL_VAR NAME="editionstatement" --><!-- /TMPL_IF --> <!-- TMPL_IF NAME="editionresponsability" --><!-- TMPL_VAR NAME="editionresponsability" --><!-- /TMPL_IF --> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl >index b1fdf84..1e67160 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl >@@ -70,7 +70,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <div id="catalogue_detail_biblio"> > > <div id="bookcover"> >- <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="OPACURLOpenInNewWindow" --><a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link" target="_blank"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="Cover Image" /></a><!-- /TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF --> >+ <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="OPACURLOpenInNewWindow" --><a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->" target="_blank"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="Cover Image" /></a><!-- /TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF --> > > <!-- TMPL_IF NAME="SyndeticsEnabled" --><!-- TMPL_IF NAME="SyndeticsCoverImages" --><!-- TMPL_IF NAME="content_identifier_exists" --><!-- TMPL_IF NAME="using_https" --> > <img src="https://secure.syndetics.com/index.aspx?isbn=<!-- TMPL_VAR NAME="normalized_isbn" -->/<!-- TMPL_VAR NAME="SyndeticsCoverImageSize" -->.GIF&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" -->&type=xw10&upc=<!-- TMPL_VAR NAME="normalized_upc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" -->" alt="" class="thumbnail" /> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl >index 70b27f6..baae1e5 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tmpl >@@ -49,7 +49,7 @@ TMPL_ELSE -->Title<!-- /TMPL_UNLESS --></th> > > <!-- TMPL_UNLESS NAME="__odd__" --><tr class="highlight"><!-- TMPL_ELSE --><tr><!-- /TMPL_UNLESS --> > <td> >-<!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><span class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF --> >+<!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><span class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF --> > > <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF NAME="normalized_isbn" --><div style="block" title="<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->" class="<!-- TMPL_VAR name="normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR NAME="__counter__"-->"></div><!-- TMPL_ELSE --><span class="no-image">No cover image available</span><!-- /TMPL_IF --><!-- /TMPL_IF --> > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl >index 4749985..2661538 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tmpl >@@ -220,7 +220,7 @@ $.tablesorter.addParser({ > > <!-- TMPL_IF NAME="JacketImages" --><td class="jacketcell"> > >-<!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><a href="#"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> >+<!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->" title="View at Amazon.com"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><a href="#"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> > > <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF NAME="normalized_isbn" --><div style="display:block;" title="Click to view in Google Books" class="<!-- TMPL_VAR NAME="normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR NAME="__counter__"-->"></div><!-- TMPL_ELSE --><a href="http://books.google.com/books?q=<!-- TMPL_VAR NAME="title" escape="url" -->"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> > >@@ -295,7 +295,7 @@ $.tablesorter.addParser({ > <tr> > <!-- TMPL_IF NAME="JacketImages" --><td class="jacketcell"> > >-<!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="" class="thumbnail" /></a><!-- TMPL_ELSE --><a href="#"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> >+<!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" --><!-- TMPL_IF NAME="AmazonAssocTag" -->?tag=<!-- TMPL_VAR NAME="AmazonAssocTag" --><!-- /TMPL_IF -->" title="View at Amazon.com"><img src="http://images.amazon.com/images/P/<!-- TMPL_VAR name="normalized_isbn" -->.01.THUMBZZZ.jpg" alt="" class="thumbnail" /></a><!-- TMPL_ELSE --><a href="#"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> > > <!-- TMPL_IF NAME="GoogleJackets" --><!-- TMPL_IF NAME="normalized_isbn" --><div style="display:block;" title="Click to view in Google Books" class="<!-- TMPL_VAR NAME="normalized_isbn" -->" id="gbs-thumbnail<!--TMPL_VAR NAME="__counter__"-->"></div><!-- TMPL_ELSE --><a href="http://books.google.com/books?q=<!-- TMPL_VAR NAME="title" escape="url" -->"><span class="no-image">No cover image available</span></a><!-- /TMPL_IF --><!-- /TMPL_IF --> > >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4460
:
2165
|
10024
|
10110
|
10600
|
10686
|
52670
|
54746
|
57688
|
60127
|
62921
|
62922
|
63328