PRECONDITIONS| -------------+ UseBranchTranferLimits, itemtype BK IPT -> CPL -> FFL -> IPT no transfers into KIR all tranfers to SPR ----------------------- --- opac-reserve.pl --- ----------------------- Testing showing multiple biblios and limiting by UseBranchTranferLimits CASE1: get single alert. Biblio1 Item's holdingbranch pickupbranch canReserve? CPL IPT 0 CPL IPT 0 FFL IPT 1 IPT IPT 1 No notifications shown Biblio2 Item's holdingbranch pickupbranch canReserve? CPL IPT 0 CPL IPT 0 Show "No transfers available notification" Biblio3 Item's holdingbranch pickupbranch canReserve? no items Show "No items available" Submitting holds:> alert(Biblio2 has no transferrable items), submit fails. CASE2: get multiple alerts Biblio1 Item's holdingbranch pickupbranch canReserve? CPL KIR 0 CPL KIR 0 FFL KIR 0 IPT KIR 0 Show "No transfers available notification" Biblio2 Item's holdingbranch pickupbranch canReserve? CPL KIR 0 CPL KIR 0 Show "No transfers available notification" Biblio3 Item's holdingbranch pickupbranch canReserve? no items Show "No items available" Submitting holds:> alert(Biblio1 && Biblio2 has no transferrable items), submit fails. CASE3: place multiple holds Biblio1 Item's holdingbranch pickupbranch canReserve? CPL CPL 1 CPL CPL 1 FFL CPL 0 IPT CPL 1 No notifications shown Biblio2 Item's holdingbranch pickupbranch canReserve? CPL CPL 1 CPL CPL 1 No notifications shown Biblio3 Item's holdingbranch pickupbranch canReserve? no items Show "No items available" Submitting holds:> submit ok. CASE4: Break the bejesus out of this crap! It is possible to place a title-level hold on a biblio even if no items are transferrable. This is done by smartly messing around with the form and pressing enter at the right position. Managed to submit the form once, but haven't been able to replicate the issue. OR Make a POST-request from an external site. Forging biblionumbers- and selecteditems-lists and other osed parameters. BranchTransferLimits are checked in business layer (opac-reserve.pl) as well after submitting the form. No special error is given for the failing reservation. One should know better.