Bugzilla – Attachment 22013 Details for
Bug 11058
Compile time warning issued by C4/Record.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 11058: make variable name unique within its scope
SIGNED-OFF-Bug-11058-make-variable-name-unique-wit.patch (text/plain), 1.19 KB, created by
Mark Tompsett
on 2013-10-16 10:25:47 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 11058: make variable name unique within its scope
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2013-10-16 10:25:47 UTC
Size:
1.19 KB
patch
obsolete
>From 72c273c994a6ec6cf86e6c89b48f19cbe73dc88d Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 16 Oct 2013 10:09:12 +0100 >Subject: [PATCH] [SIGNED OFF] Bug 11058: make variable name unique within its > scope > >routine declares two lexical variables named $stylesheet >rename the second to keep code clearer and >avoid propagating compile time warnings > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > C4/Record.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Record.pm b/C4/Record.pm >index 7277f2c..9d72d5a 100644 >--- a/C4/Record.pm >+++ b/C4/Record.pm >@@ -310,9 +310,9 @@ sub _transformWithStylesheet { > my $xslt = XML::LibXSLT->new(); > my $source = $parser->parse_string($xmlrecord); > my $style_doc = $parser->parse_file($xslfile); >- my $stylesheet = $xslt->parse_stylesheet($style_doc); >- my $results = $stylesheet->transform($source); >- my $newxmlrecord = $stylesheet->output_string($results); >+ my $style_sheet = $xslt->parse_stylesheet($style_doc); >+ my $results = $style_sheet->transform($source); >+ my $newxmlrecord = $style_sheet->output_string($results); > return ($newxmlrecord); > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11058
:
22010
|
22013
|
22227