Bugzilla – Attachment 22861 Details for
Bug 10928
Acq Note does not appear when receiving an order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10928 - Make orders note visible when receiving an order
0001-new.patch (text/plain), 2.18 KB, created by
Mathieu Saby
on 2013-11-11 21:27:43 UTC
(
hide
)
Description:
Bug 10928 - Make orders note visible when receiving an order
Filename:
MIME Type:
Creator:
Mathieu Saby
Created:
2013-11-11 21:27:43 UTC
Size:
2.18 KB
patch
obsolete
>From f9b2a0266a1cb89bf0061d55460383a1e83c5724 Mon Sep 17 00:00:00 2001 >From: Mathieu Saby <mathieu.saby@univ-rennes2.fr> >Date: Mon, 11 Nov 2013 22:21:28 +0100 >Subject: [PATCH] Bug 10928 - Make orders note visible when receiving an order >Content-Type: text/plain; charset="utf-8" > >notes field is used in biblio table as well as in aqorders table, so results are messed up. >The SQL query in C4:Acquisitions:SearchOrders must be changed. >This is also the case for timestamp field. > >This patch change C4:Acquisitions:SearchOrders: >- biblio.* is replaced with all fields of biblio table >- except for notes, returned as biblionotes and tilmestamp as bibliotimestamp > >Further improvements could be made later (as suppressing useless biblio.fields from the query). > >To test : >create an order with an order note >receive this order, and check the order note is visible in the textarea dedicated to that purpose > > >--- > C4/Acquisition.pm | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index aabc0ed..bb604e7 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1650,7 +1650,8 @@ C<$pending> Finds pending orders. Ignores completed and cancelled orders. > > > C<@results> is an array of references-to-hash with the keys are fields >-from aqorders, biblio, biblioitems and aqbasket tables. >+from aqorders, biblio, biblioitems and aqbasket tables, except for >+biblio.notes returned as biblionotes and biblio.timestamp returned as bibliotimestamp. > > =cut > >@@ -1672,7 +1673,17 @@ sub SearchOrders { > SELECT aqbasket.basketno, > borrowers.surname, > borrowers.firstname, >- biblio.*, >+ biblio.frameworkcode, >+ biblio.author, >+ biblio.title, >+ biblio.unititle, >+ biblio.serial, >+ biblio.seriestitle, >+ biblio.copyrightdate, >+ biblio.datecreated, >+ biblio.abstract, >+ biblio.notes as biblionotes, >+ biblio.timestamp as bibliotimestamp, > biblioitems.isbn, > biblioitems.biblioitemnumber, > aqbasket.closedate, >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10928
: 22861